[Rt-commit] rtir branch, 5.0/remove-incident-reply-page-menu, created. 5.0.0beta1-3-g14fdaf1b

[? sunnavy]

The branch, 5.0/remove-incident-reply-page-menu has been created
        at  14fdaf1b72488e27ede63ed00fced4e39648fe07 (commit)

- Log -----------------------------------------------------------------
commit 14fdaf1b72488e27ede63ed00fced4e39648fe07
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Jul 2 02:22:07 2020 +0800

    Remove the confusing incident Reply page menu
    
    The page menu was added along with refine page in 1e27969b79 so users
    can easily jump between reply and refine pages. Since we switched to RT
    search pages, the jump doesn't work any more because we didn't add
    "Reply" on RT search page accordingly.
    
    Currently we actually have 2 reply actions("Reply to Reporters" and
    "Reply to All"), even though the menu remembers if it's "Reply to
    Reporters" and "Reply to All" on current page, it still confuses people.

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index 44eca7d1..16fb1979 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -461,10 +461,6 @@ if ( $request_path =~ m{(?:$re_rtir_path)(?:$re_rtir_types/)?(Display|Edit|Updat
         RTIR             => 1,
     );
 
-    PageMenu()->child(
-        link => title => loc('Reply'),
-        path => RT::IR->HREFTo("Incident/Reply/?". $query_string->( %args ), IncludeWebPath => 0),
-    );
     PageMenu()->child(
         edit_search => title => loc('Edit Search'),
         path => '/Search/Build.html?' . $query_string->( %args, ResultPage => RT::IR->HREFTo('Incident/Reply/') ),
diff --git a/t/009-attachments-processing.t b/t/009-attachments-processing.t
index 70e7ea24..07e8ce45 100644
--- a/t/009-attachments-processing.t
+++ b/t/009-attachments-processing.t
@@ -203,11 +203,6 @@ $agent->goto_create_rtir_ticket('Countermeasures');
 
     $agent->display_ticket( $inc_id);
     $agent->follow_link_ok({text => 'Reply to Reporters'}, "go to 'Reply to Reporters'");
-    $agent->content_contains( "<input type=\"checkbox\" name=\"SelectedReportsAll\" value=\"1\" checked=\"checked\"",
-                              'Checkboxes checked for reply all');
-
-    $agent->follow_link_ok({text => 'Reply'}, "Confirm 'Reply' link returns here in same state");
-
     $agent->content_contains( "<input type=\"checkbox\" name=\"SelectedReportsAll\" value=\"1\" checked=\"checked\"",
                               'Checkboxes checked for reply all');
 

-----------------------------------------------------------------------