[Rt-commit] rt branch, 5.0/convert-fulltextsearch-utf8mb4, updated. rt-5.0.0beta1-47-g560c3e1dfc

[Aaron Trevena]

The branch, 5.0/convert-fulltextsearch-utf8mb4 has been updated
       via  560c3e1dfc72fdb73cdd9698c08c2fb65b0a90be (commit)
      from  f335b0827905d015436a63dd395d5d7261a7e4d5 (commit)

Summary of changes:
 docs/UPGRADING-5.0    | 5 ++---
 etc/upgrade/4.5.8/ddl | 4 ----
 2 files changed, 2 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit 560c3e1dfc72fdb73cdd9698c08c2fb65b0a90be
Author: Aaron Trevena <ast at bestpractical.com>
Date:   Fri Jul 3 14:35:05 2020 +0100

    Remove flag to skip bigint/utf8mb update
    
    Remove flag to skip update in ddl script and update documentation on
    how to skip using normal upgrade process.

diff --git a/docs/UPGRADING-5.0 b/docs/UPGRADING-5.0
index 985917b873..56f5d77de7 100644
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@ -60,9 +60,8 @@ space, it can cause this step to fail.
 
 If you have Fulltext searching enabled in mysql, mariadb or postgres this
 step can require a significantly large amount of disk space and you can skip
-this step for the fulltexts search index table by setting
-NoFulltextsearchTableUpgrade to 1 in the $FullTextSearch section of your
-RT configuration.
+this step for the fulltexts search index table by skipping the db upgrade in 4.5.8,
+i.e. run make upgrade-database twice, first to 4.5.7 then from 4.5.9
 
 =back
 
diff --git a/etc/upgrade/4.5.8/ddl b/etc/upgrade/4.5.8/ddl
index 4bee078730..40bf8ed005 100644
--- a/etc/upgrade/4.5.8/ddl
+++ b/etc/upgrade/4.5.8/ddl
@@ -13,10 +13,6 @@ push @Final, sub {
     my $db_type = RT->Config->Get('DatabaseType');
     return 1 unless ($db_type eq 'Pg' or $db_type eq 'mysql');
 
-    # check we don't have a flag or config to not upgrade to bigint as the
-    # size of tables could be large and users may want to do this as a seperate step
-    return 1 if ($fts_config->{'NoFulltextsearchTableUpgrade'});
-
     my $dbh = $args{dbh};
 
     # get tablename from config, fall back to default tablename

-----------------------------------------------------------------------