[Rt-commit] rt branch, 5.0.0-releng, updated. rt-5.0.0beta2-57-g72794f1126

[? sunnavy]

The branch, 5.0.0-releng has been updated
       via  72794f112630bfa59e58ebcf9483a2c2a70a4a39 (commit)
       via  c62335c9c52d6b706f09f534b6d598e38d69d831 (commit)
       via  15955a09cf4fd23a0ce2b3e375efa4be24eb5ba8 (commit)
      from  a508cd91b2c92e6731fc9b37feabcd104cc2ed27 (commit)

Summary of changes:
 docs/UPGRADING-5.0                       | 26 ++++++++------------------
 share/html/Elements/ColumnMap            |  6 ------
 share/html/Elements/RT__Ticket/ColumnMap |  4 ++--
 3 files changed, 10 insertions(+), 26 deletions(-)

- Log -----------------------------------------------------------------
commit 15955a09cf4fd23a0ce2b3e375efa4be24eb5ba8
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Jul 9 17:02:20 2020 -0400

    Set default Owner/OwnerName column map to read-only
    
    Inline edit loads an Owner dropdown for every ticket
    row in search results when it is enabled. Depending on
    the rights configuration and the number of users with the
    OwnTicket right, even a single Owner dropdown can take
    extra time to render. To avoid possible performance issues
    with search results after upgrade, change OwnerName, the
    default format used in many searches, to view-only.
    
    Make the new inline edit version available in a new format
    OwnerNameEdit which users can optionally use by updating
    searches.

diff --git a/share/html/Elements/ColumnMap b/share/html/Elements/ColumnMap
index d9b14bbd0b..17a39a0ec5 100644
--- a/share/html/Elements/ColumnMap
+++ b/share/html/Elements/ColumnMap
@@ -279,12 +279,6 @@ if ($RecordClass->DOES("RT::Record::Role::Roles")) {
                 value => sub { return \($m->scomp("/Elements/ShowPrincipal", Object => $_[0]->RoleGroup($role) ) ) },
             };
 
-            if ( $RecordClass eq 'RT::Ticket' && $role eq 'Owner' ) {
-                $ROLE_MAP->{$RecordClass}{$role}{edit} = sub {
-                    return \($m->scomp('/Elements/SelectOwner', TicketObj => $_[0], Name => 'Owner', Default => $_[0]->OwnerObj->Id, DefaultValue => 0));
-                };
-            }
-
             $ROLE_MAP->{$RecordClass}{$role . "s"} = $ROLE_MAP->{$RecordClass}{$role}
                 unless $attrs->{Single};
         }
diff --git a/share/html/Elements/RT__Ticket/ColumnMap b/share/html/Elements/RT__Ticket/ColumnMap
index 37a71a00d5..19d303c495 100644
--- a/share/html/Elements/RT__Ticket/ColumnMap
+++ b/share/html/Elements/RT__Ticket/ColumnMap
@@ -104,12 +104,12 @@ $COLUMN_MAP = {
         value     => sub { return $_[0]->QueueObj->Name },
         edit      => sub { return \($m->scomp('/Elements/SelectQueue', Default => $_[0]->Queue, Name => 'Queue', ShowNullOption => 0)) },
     },
-    OwnerDisplayOnly =>  {
+    OwnerName =>  {
         title     => 'Owner', # loc
         attribute => 'Owner',
         value     => sub { return \($m->scomp("/Elements/ShowUser", User => $_[0]->OwnerObj)) },
     },
-    OwnerName => {
+    OwnerNameEdit => {
         title     => 'Owner', # loc
         attribute => 'Owner',
         value     => sub { return $_[0]->OwnerObj->Name },

commit c62335c9c52d6b706f09f534b6d598e38d69d831
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Jul 9 17:16:40 2020 -0400

    Update notes on Owner inline edit options

diff --git a/docs/UPGRADING-5.0 b/docs/UPGRADING-5.0
index 70d17cb263..bd78a58d86 100644
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@ -151,30 +151,20 @@ updated GnuPG package with some version of 2.2.
 =item *
 
 RT search results now allow inline editing of ticket metadata, greatly
-improving usability and convenience.
+improving usability and convenience. Editable fields are now the default
+for most ticket fields in search results.
 
-Some fields that require extra processing per ticket, particularly Owner, may
-result in slower page load times. If you experience these slower page loads,
-there are a few options to improve performance:
+The ticket Owner field sometimes requires extra work to build and can
+result in slower page load times, so the default Owner format is
+read-only. To enable inline edit for Owner, update your search to use
+the format OwnerNameEdit.
 
-=over
-
-=item *
-
-Display Owner as an autocomplete box rather than a dropdown using the
+If you experience slower page loads with OwnerNameEdit, you can
+display Owner as an autocomplete box rather than a dropdown using the
 L<AutocompleteOwners|https://docs.bestpractical.com/rt/4.4.4/RT_Config.html#AutocompleteOwners>
 configuration option. This may also help other areas of RT in addition to
 searches.
 
-=item *
-
-Update your search result format to use OwnerDisplayOnly rather than OwnerName
-in search results. This will disable inline edit for the Owner field, but this
-may be acceptable if the search is not used for editing or users don't have
-rights to edit Owner.
-
-=back
-
 We are investigating options to improve the underlying queries. Some users have
 reported improved performance with the following indexes, at least on Postgres:
 

commit 72794f112630bfa59e58ebcf9483a2c2a70a4a39
Merge: a508cd91b2 c62335c9c5
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jul 11 01:16:04 2020 +0800

    Merge branch '5.0/default-ownername-view-only' into 5.0.0-releng


-----------------------------------------------------------------------