[Rt-commit] rt branch, 5.0/admin-rt-maintenance-callback, repushed

Aaron Trevena ast at bestpractical.com
Fri Jul 31 07:09:18 EDT 2020


The branch 5.0/admin-rt-maintenance-callback was deleted and repushed:
       was ed3907e42f4dfeadc9add9edaee641ce3811ea13
       now 5d4072bc58b3d0526a1653d50ab766cf92990305

1: 12c37799bf ! 1: 5d4072bc58 Add portlets callback to admin page and update styling
    @@ -1,8 +1,12 @@
     Author: Aaron Trevena <ast at bestpractical.com>
     
    -    Add portlets callback to admin page
    +    Add portlets callback to admin page and update styling
         
         Add portlets callback to admin page and update styling as needed
    +    
    +    The iframe is itself a different "document" in the DOM, so you can't target it with elements in the parent dom and it's own dom,
    +    also the class in admin.css wasn't matching the iframe or it's parents, as the class was used in the iframe source document
    +    rather than the page containing the iframe
     
     diff --git a/share/html/Admin/Elements/Portal b/share/html/Admin/Elements/Portal
     --- a/share/html/Admin/Elements/Portal
    @@ -13,7 +17,8 @@
      %# END BPS TAGGED BLOCK }}}
     -<div id="rt-portal">
      <&| /Widgets/TitleBox, title => loc('RT Portal') &>
    - <iframe src="https://bestpractical.com/rt/integration/news?utm_source=rt&utm_medium=iframe&utm_campaign=<%$RT::VERSION%>"></iframe>
    +-<iframe src="https://bestpractical.com/rt/integration/news?utm_source=rt&utm_medium=iframe&utm_campaign=<%$RT::VERSION%>"></iframe>
    ++<iframe src="https://bestpractical.com/rt/integration/news?utm_source=rt&utm_medium=iframe&utm_campaign=<%$RT::VERSION%>" class="rt-portlet"></iframe>
      </&>
     -</div>
     
    @@ -28,10 +33,10 @@
     -<& /Elements/ListMenu, menu => Menu()->child('admin')  &>
     +  <& /Elements/Tabs &>
     +<div class="row">
    -+<div class="boxcontainer col-md-8">
    ++<div class="boxcontainer col-md-5">
     +  <& /Elements/ListMenu, menu => Menu()->child('admin')  &>
     +</div>
    -+<div class="boxcontainer col-md-4">
    ++<div class="boxcontainer col-md-7">
      % if (RT->Config->Get('ShowRTPortal')) {
      <& /Admin/Elements/Portal &>
      % }
    @@ -52,4 +57,14 @@
      ul.list-menu > li {
          margin-bottom: .5em;
          margin-top: .5em;
    -
    +@@
    +  margin-right: 0.5em;
    + }
    + 
    +-#rt-portal .titlebox iframe {
    +-    height: 100%;
    ++iframe.rt-portlet {
    ++    height: 200px;
    +     width: 100%;
    +     border: 0;
    + }
2: 27d25acf9d < -:  ------- Fix styling for iframes in Admin page
3: ed3907e42f < -:  ------- Fix styling of iframes in admin page



More information about the rt-commit mailing list