[Rt-commit] rt branch, 5.0/fix-edit-cf-dropdown-color-dark-theme, created. rt-5.0.0beta1-1-ga8a5c49fc7

Blaine Motsinger blaine at bestpractical.com
Mon Jun 8 16:15:30 EDT 2020


The branch, 5.0/fix-edit-cf-dropdown-color-dark-theme has been created
        at  a8a5c49fc7ef1d7eea8248e73db5c1c982b5dcd3 (commit)

- Log -----------------------------------------------------------------
commit a8a5c49fc7ef1d7eea8248e73db5c1c982b5dcd3
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Mon Jun 8 15:09:30 2020 -0500

    Fix edit CF dropdown color for dark theme
    
    This commit fixes the Custom Field select dropdown background color
    by adding in a missing form-control class.
    
    With the class added, the correct color is applied without a
    separate css definition to fix it.  After removing the rule to fix
    form-control, textarea needed to be specifically targeted for the
    same background color.

diff --git a/share/html/Elements/EditCustomFieldSelect b/share/html/Elements/EditCustomFieldSelect
index edeebd410c..ee796758b2 100644
--- a/share/html/Elements/EditCustomFieldSelect
+++ b/share/html/Elements/EditCustomFieldSelect
@@ -94,7 +94,7 @@
 <select
   name="<%$name%>" id="<%$name%>"
 
-    class="CF-Edit CF-<%$CustomField->id%>-Edit <% $RenderType eq 'Dropdown' ? 'selectpicker' : 'form-control' %>"
+    class="CF-Edit CF-<%$CustomField->id%>-Edit <% $RenderType eq 'Dropdown' ? 'selectpicker form-control' : 'form-control' %>"
 %   if ( $use_chosen ) {
     data-live-search="true"
 %   }
diff --git a/share/static/css/elevator-dark/main.css b/share/static/css/elevator-dark/main.css
index 3874c165ab..c94a7709c5 100644
--- a/share/static/css/elevator-dark/main.css
+++ b/share/static/css/elevator-dark/main.css
@@ -262,7 +262,7 @@
     border-top: 1px solid #515151;
 }
 
-.darkmode .form-control,
+.darkmode textarea,
 .darkmode .selectize-input {
     background: #323D42 !important;
     border-color: #717171;

-----------------------------------------------------------------------


More information about the rt-commit mailing list