[Rt-commit] rt branch, 4.4/searching-retain-row-limit, repushed

Craig Kaiser craig at bestpractical.com
Wed Jun 17 08:13:01 EDT 2020


The branch 4.4/searching-retain-row-limit was deleted and repushed:
       was ae9f845d2a5ca9c2cc79bd9a8c40271b99952e09
       now 2ca905bed602448e4eacd33283997c957c36a003

1: ae9f845d2a ! 1: 2ca905bed6 Add default rows per page for search results from saved chart
    @@ -30,10 +30,13 @@
              $current_search_menu->child( advanced =>
                  title => loc('Advanced'),    path => "/Search/Edit.html$args" );
              if ($has_query) {
    -+            # If we load a saved chart we want to have a default sensible rows per page value
    ++            # If we load a saved chart we need to set a default RowsPerPage value
    ++            # or else when going to the results page from the saved chart the results
    ++            # set will have no pagination and be unlimited.
    ++            # We use 50 as the default value as it is the default value on the query builder page.
     +            if ( $request_path =~ m{^/Search/Chart.html} && $final_query_args{'SavedChartSearchId'} ) {
     +                unless ( defined $final_query_args{'RowsPerPage'} ) {
    -+                    $args =~ s/RowsPerPage=/RowsPerPage=10/;
    ++                    $args =~ s/RowsPerPage=/RowsPerPage=50/;
     +                }
     +            }
     +



More information about the rt-commit mailing list