[Rt-commit] rt branch, 5.0/expensive-owner-inline-edit2, created. rt-5.0.0beta1-43-g5aa03fc21d

[Jim Brandt]

The branch, 5.0/expensive-owner-inline-edit2 has been created
        at  5aa03fc21d4911f2066783ab96565a6dc9d3fa74 (commit)

- Log -----------------------------------------------------------------
commit 005a0ebaf0541fc311ced1a85dc7e26452db836e
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jun 26 16:37:43 2020 -0400

    Add a display only Owner column as an alternative to OwnerName
    
    OwnerName now defaults to inline edit and loading the Owner
    dropdown on large result sets can cause very slow page
    loads. Provide an display-only alternative.

diff --git a/share/html/Elements/RT__Ticket/ColumnMap b/share/html/Elements/RT__Ticket/ColumnMap
index 6e446bf030..358874d95a 100644
--- a/share/html/Elements/RT__Ticket/ColumnMap
+++ b/share/html/Elements/RT__Ticket/ColumnMap
@@ -104,6 +104,12 @@ $COLUMN_MAP = {
         value     => sub { return $_[0]->QueueObj->Name },
         edit      => sub { return \($m->scomp('/Elements/SelectQueue', Default => $_[0]->Queue, Name => 'Queue', ShowNullOption => 0)) },
     },
+    OwnerDisplayOnly =>  {
+        title     => 'Owner', # loc
+        attribute => 'Owner',
+        value     => sub { return sprintf('%s (%s)',$_[0]->OwnerObj->Name, $_[0]->OwnerObj->RealName) },
+
+    },
     OwnerName => {
         title     => 'Owner', # loc
         attribute => 'Owner',
diff --git a/share/html/Search/Elements/BuildFormatString b/share/html/Search/Elements/BuildFormatString
index 09865e60b4..e6ec43a1eb 100644
--- a/share/html/Search/Elements/BuildFormatString
+++ b/share/html/Search/Elements/BuildFormatString
@@ -151,7 +151,7 @@ else {
         Status ExtendedStatus UpdateStatus
         Type
 
-        OwnerName Requestors Cc AdminCc CreatedBy LastUpdatedBy
+        OwnerName OwnerDisplayOnly Requestors Cc AdminCc CreatedBy LastUpdatedBy
 
         Priority InitialPriority FinalPriority
 

commit 5aa03fc21d4911f2066783ab96565a6dc9d3fa74
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jun 26 17:00:14 2020 -0400

    Document possible slow page loads with OwnerName column

diff --git a/docs/UPGRADING-5.0 b/docs/UPGRADING-5.0
index e82a5670d0..2a303b915a 100644
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@ -148,7 +148,42 @@ RT should also still run with GnuPG 1.4.x. It is not supported for GnuPG version
 2.0 or 2.1. On some Linux systems, you may need to add a new repo to get an
 updated GnuPG package with some version of 2.2.
 
+=item *
+
+RT search results now allow inline editing of ticket metadata, greatly
+improving usability and convenience.
+
+Some fields that require extra processing per ticket, particularly Owner, may
+result in slower page load times. If you experience these slower page loads,
+there are a few options to improve performance:
+
+=over
+
+=item *
+
+Display Owner as an autocomplete box rather than a dropdown using the
+L<AutocompleteOwners|https://docs.bestpractical.com/rt/4.4.4/RT_Config.html#AutocompleteOwners>
+configuration option. This may also help other areas of RT in addition to
+searches.
+
+=item *
+
+Update your search result format to use OwnerDisplayOnly rather than OwnerName
+in search results. This will disable inline edit for the Owner field, but this
+may be acceptable if the search is not used for editing or users don't have
+rights to edit Owner.
+
 =back
 
-=cut
+We are investigating options to improve the underlying queries. Some users have
+reported improved performance with the following indexes, at least on Postgresql:
+
+   CREATE INDEX ACL2 ON acl (objecttype, objectid);
+   CREATE INDEX ACL3 ON acl (principalid, rightname, principaltype);
 
+We are performing testing and looking for additional feedback before adding these
+to default RT.
+
+=back
+
+=cut

-----------------------------------------------------------------------