[Rt-commit] rt branch, 5.0/convert-fulltextsearch-utf8mb4, created. rt-5.0.0beta1-44-gfb59da120c

[Aaron Trevena]

The branch, 5.0/convert-fulltextsearch-utf8mb4 has been created
        at  fb59da120ce967900fb4be1e14e643082a7beb15 (commit)

- Log -----------------------------------------------------------------
commit fb59da120ce967900fb4be1e14e643082a7beb15
Author: Aaron Trevena <ast at bestpractical.com>
Date:   Tue Jun 30 19:19:00 2020 +0100

    Update fulltextsearch table to new utf8mb4 charset
    
    Add table encoding change for fulltextsearch table in
    upgrade script for 4.5.7

diff --git a/docs/UPGRADING-5.0 b/docs/UPGRADING-5.0
index bbf7f175c8..985917b873 100644
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@ -58,8 +58,11 @@ while running because MySQL, MariaDB, and Postgres will create a
 temporary copy of the table while running. If you don't have sufficient
 space, it can cause this step to fail.
 
-You can skip this step by setting NoBigintUpgrade to 1 in the $FullTextSearch
-section of your RT configuration.
+If you have Fulltext searching enabled in mysql, mariadb or postgres this
+step can require a significantly large amount of disk space and you can skip
+this step for the fulltexts search index table by setting
+NoFulltextsearchTableUpgrade to 1 in the $FullTextSearch section of your
+RT configuration.
 
 =back
 
diff --git a/etc/upgrade/4.5.8/content b/etc/upgrade/4.5.8/content
index 19ddfc9133..6bedd6a907 100644
--- a/etc/upgrade/4.5.8/content
+++ b/etc/upgrade/4.5.8/content
@@ -14,7 +14,7 @@ push @Final, sub {
 
     # check we don't have a flag or config to not upgrade to bigint as the
     # size of tables could be large and users may want to do this as a seperate step
-    return if ($fts_config->{'NoBigintUpgrade'} or $ENV{NO_BIGINT_UPGRADE});
+    return if ($fts_config->{'NoFulltextsearchTableUpgrade'});
 
     my $dbh = RT->DatabaseHandle->dbh;
 
@@ -40,7 +40,7 @@ sub get_pg_ddl_query {
 
 sub get_mysql_ddl_query {
     my ($table) = @_;
-    return "ALTER TABLE $table MODIFY id BIGINT NOT NULL AUTO_INCREMENT;";
+    return "ALTER TABLE $table MODIFY id BIGINT NOT NULL AUTO_INCREMENT, CONVERT TO CHARACTER SET utf8mb4;";
 }
 
 sub table_exists {

-----------------------------------------------------------------------