[Rt-commit] rt branch, 4.6/unread-message-count, updated. rt-4.4.4-543-ga756476ef

Aaron Trevena ast at bestpractical.com
Tue Mar 10 16:31:40 EDT 2020


The branch, 4.6/unread-message-count has been updated
       via  a756476ef258e170f6990c6ebf319f482a36ac15 (commit)
       via  c703d527338944dae64b3f6c8a7ac565dc4ea6ed (commit)
      from  baa67be8b2c07157148ab86df9152174bdd34f21 (commit)

Summary of changes:
 lib/RT/Ticket.pm                         | 1 -
 share/html/Elements/RT__Ticket/ColumnMap | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit c703d527338944dae64b3f6c8a7ac565dc4ea6ed
Author: Aaron Trevena <ast at bestpractical.com>
Date:   Tue Mar 10 20:09:50 2020 +0000

    Fix tx limit in unseen count for ticket

diff --git a/lib/RT/Ticket.pm b/lib/RT/Ticket.pm
index d43b0e58c..ae797b706 100644
--- a/lib/RT/Ticket.pm
+++ b/lib/RT/Ticket.pm
@@ -2623,7 +2623,6 @@ sub SeenUpTo {
         OPERATOR => '>',
         VALUE => $attr->Content
     ) if $attr;
-    $txns->RowsPerPage(1);
 
     my $next_unread_txn = $txns->First;
     if (wantarray) {

commit a756476ef258e170f6990c6ebf319f482a36ac15
Author: Aaron Trevena <ast at bestpractical.com>
Date:   Tue Mar 10 20:31:13 2020 +0000

    improve unread message link text
    
    localize title and use bootstrap tooltip

diff --git a/share/html/Elements/RT__Ticket/ColumnMap b/share/html/Elements/RT__Ticket/ColumnMap
index 64d287298..c2cf043f1 100644
--- a/share/html/Elements/RT__Ticket/ColumnMap
+++ b/share/html/Elements/RT__Ticket/ColumnMap
@@ -345,7 +345,8 @@ $COLUMN_MAP = {
             $link .= ( $session{'CurrentUser'}->Privileged ) ? '/Ticket/Display.html?id=' : '/SelfService/Display.html?id=';
             $link .= $self->id .'&MarkAsSeen=1&Anchor=txn-'. $first_unread->id;
 
-            return \('<a title="jump to Unread & Mark as Seen" href="'. $link .'"><b>'),
+            my $title = loc("Jump to Unread & Mark as Seen");
+            return \('<a data-toggle="tooltip" data-original-title="' . $title . '" href="'. $link .'"><b>'),
             $count, \'</b></a>';
         }
    }

-----------------------------------------------------------------------


More information about the rt-commit mailing list