[Rt-commit] rt branch, 4.6/search-selection-next, repushed

[Blaine Motsinger]

The branch 4.6/search-selection-next was deleted and repushed:
       was c1241483459f4c6b0e2ef00cd9ee2e4f5e649129
       now 7d7a5ec6c9af3d61141ac51ff1e002970a83b484

1: 2aab9ecde = 1: 2aab9ecde Add RT-Extension-DashboardSelectionUI to core
2: 6deca7f57 = 2: 6deca7f57 Upgrade jQuery ui sortable and add disableSelection
3: dd7e3e5e8 = 3: dd7e3e5e8 Update DashboardSelectionUI to elevator-light
4: 5d2fb31b1 = 4: 5d2fb31b1 Switch remove icon to fontawesome
5: f554b70cb = 5: f554b70cb Fix reset to defaults
6: 0cc961e47 = 6: 0cc961e47 Force redirect back to the current page on submit
7: e5ff16c4d = 7: e5ff16c4d Add name to forms for UpdateDashboard
8: c12414834 ! 8: 7d7a5ec6c Update tests for MyRT Helper changes
    @@ -6,6 +6,109 @@
         updated to now post JSON to a Helper, instead of form values to
         the page itself.  This commit updates the tests to also post JSON
         to the Helper.
    +
    +diff --git a/t/mail/dashboards.t b/t/mail/dashboards.t
    +--- a/t/mail/dashboards.t
    ++++ b/t/mail/dashboards.t
    +@@
    +     $m->click_button(value => 'Create');
    +     $m->title_is('Modify the dashboard Testing!');
    + 
    ++    my ( $dashboard_id ) = ( $m->uri =~ /id=(\d+)/ );
    ++    ok( $dashboard_id, "got a dashboard ID, $dashboard_id" );  # 8
    ++
    +     $m->follow_link_ok({text => 'Content'});
    +     $m->title_is('Modify the content of dashboard Testing!');
    + 
    +-    my $form = $m->form_name('Dashboard-Searches-body');
    +-    my @input = $form->find_input('Searches-body-Available');
    +-    my ($dashboards_component) =
    +-        map { ( $_->possible_values )[1] }
    +-        grep { ( $_->value_names )[1] =~ /Dashboards/ } @input;
    +-    $form->value('Searches-body-Available' => $dashboards_component );
    +-    $m->click_button(name => 'add');
    +-    $m->content_contains('Dashboard updated');
    +-
    ++    my $payload = {
    ++        "dashboard_id" => $dashboard_id,
    ++        "panes"        => {
    ++            "body" => [
    ++                {
    ++                  "description" => "Dashboards",
    ++                  "name" => "Dashboards",
    ++                  "searchId" => "",
    ++                  "searchType" => "",
    ++                  "type" => "component"
    ++                },
    ++            ],
    ++            "sidebar" => [
    ++            ],
    ++        },
    ++    };
    ++
    ++    my $json = JSON::to_json( $payload );
    ++    my $res  = $m->post(
    ++        $baseurl . '/Helpers/UpdateDashboard',
    ++        [ content => $json ],
    ++    );
    ++    is( $res->code, 200, "added 'Dashboards' to dashboard 'Testing!'" );
    ++
    ++    $m->get_ok($baseurl . '/Dashboards/Queries.html?id=' . $dashboard_id);
    +     $m->follow_link_ok({text => 'Show'});
    +     $m->title_is('Testing! Dashboard');
    +     $m->content_contains('My dashboards');
    +     $m->content_like(qr{<a href="/Dashboards/\d+/Testing!">Testing!</a>});
    +-
    + }
    + 
    + sub create_subscription {
    +@@
    +     my $dashboard_id = $subscription->SubValue('DashboardId');
    +     ok($dashboard_id, 'got dashboard id');
    + 
    +-
    +     return ($dashboard_id, $subscription_id);
    + }
    + 
    +@@
    +     Subject => $expected_subject,
    + );
    + 
    +-
    + produces_no_dashboard_mail_ok(
    +     Name   => "no dashboard mail it's a dry run",
    +     All    => 1,
    +@@
    +     Subject =>  "[example.com] a Daily b Testing! c\n",
    + );
    + 
    +-
    + @mails = RT::Test->fetch_caught_mails;
    + is(@mails, 0, "no mail leftover");
    + 
    +@@
    +     BodyUnlike => qr/My dashboards/,
    + );
    + 
    +-
    +-
    + @mails = RT::Test->fetch_caught_mails;
    + is(@mails, 0, "no mail leftover");
    + 
    +@@
    +     Time    => $bad_time,
    + );
    + 
    +-
    + @mails = RT::Test->fetch_caught_mails;
    + is(@mails, 0, "no mail leftover");
    + 
    +@@
    +     Time    => $bad_time,
    + );
    + 
    +-done_testing;
    ++done_testing();
     
     diff --git a/t/web/custom_frontpage.t b/t/web/custom_frontpage.t
     --- a/t/web/custom_frontpage.t