[Rt-commit] rt branch, 5.0/select-one-cf-defaults-to-dropdown, created. rt-5.0.0alpha1-28-g4149953fb

[Michel Rodriguez]

The branch, 5.0/select-one-cf-defaults-to-dropdown has been created
        at  4149953fbd9a49e5db3d86af8fc6d05a8e899f19 (commit)

- Log -----------------------------------------------------------------
commit 67ee644ce566d6ff61c4cb3dc03b31fbd5c96c23
Author: michel <michel at bestpractical.com>
Date:   Fri Mar 13 22:03:00 2020 +0100

    Make "Select one value" custom fields default to "Dropdown".

diff --git a/lib/RT/CustomField.pm b/lib/RT/CustomField.pm
index 9c91e1cb9..b8bfbaa48 100644
--- a/lib/RT/CustomField.pm
+++ b/lib/RT/CustomField.pm
@@ -84,8 +84,8 @@ our %FieldTypes = (
                 'Select box',              # loc
                 'List',                    # loc
             ],
-            single => [ 'Select box',              # loc
-                        'Dropdown',                # loc
+            single => [ 'Dropdown',                # loc
+                        'Select box',              # loc
                         'List',                    # loc
                       ]
         },

commit 4149953fbd9a49e5db3d86af8fc6d05a8e899f19
Author: michel <michel at bestpractical.com>
Date:   Fri Mar 13 22:05:48 2020 +0100

    Update test for custom field render types.

diff --git a/t/api/cf_render_type.t b/t/api/cf_render_type.t
index ac090495e..b9681d006 100644
--- a/t/api/cf_render_type.t
+++ b/t/api/cf_render_type.t
@@ -15,10 +15,10 @@ diag "single select";
 );
 ok( $id, $msg );
 
-is( $cf->RenderType, 'Select box', 'default render type is Select box' );
-( $ret, $msg ) = $cf->SetRenderType('Dropdown');
-ok( $ret, 'changed to Dropdown' );
-is( $cf->RenderType, 'Dropdown', 'render type is indeed updated' );
+is( $cf->RenderType, 'Dropdown', 'default render type is Dropdown' );
+( $ret, $msg ) = $cf->SetRenderType('Select box');
+ok( $ret, 'changed to Select box' );
+is( $cf->RenderType, 'Select box', 'render type is indeed updated' );
 
 ( $ret, $msg ) = $cf->SetRenderType('List');
 ok( $ret, 'changed to List' );

-----------------------------------------------------------------------