[Rt-commit] rt branch, 5.0/fix-duplicate-ids, created. rt-5.0.0alpha1-161-g9be3c63347

[Michel Rodriguez]

The branch, 5.0/fix-duplicate-ids has been created
        at  9be3c633472aa15eb1d320eb15d4b469de83db24 (commit)

- Log -----------------------------------------------------------------
commit d1d460f6f004aae4adb7e6f81834df548a492a4b
Author: michel <michel at bestpractical.com>
Date:   Fri May 1 16:35:04 2020 +0200

    Remove duplicate "Owner" id in search results when using dropdown.

diff --git a/share/html/Elements/SelectOwnerDropdown b/share/html/Elements/SelectOwnerDropdown
index b685df8bd3..4951bd8511 100644
--- a/share/html/Elements/SelectOwnerDropdown
+++ b/share/html/Elements/SelectOwnerDropdown
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<select name="<%$Name%>" id="<%$Name%>" class="selectpicker form-control">
+<select name="<%$Name%>" class="selectpicker form-control">
 %if ($DefaultValue) {
 <option value=""<% !$Default ? qq[ selected="selected"] : '' |n %>><%$DefaultLabel |n%></option>
 %}

commit 1197000bcac60aa5dce3eb25f5c3e4f05f89630b
Author: michel <michel at bestpractical.com>
Date:   Fri May 1 16:36:45 2020 +0200

    Remove duplicate "Owner" id in search results when using autocomplete.

diff --git a/share/html/Elements/SelectOwnerAutocomplete b/share/html/Elements/SelectOwnerAutocomplete
index b47b5c750f..e7b31e94ee 100644
--- a/share/html/Elements/SelectOwnerAutocomplete
+++ b/share/html/Elements/SelectOwnerAutocomplete
@@ -72,13 +72,15 @@ my $query = $m->comp('/Elements/QueryString',
     return  => $ValueAttribute,
     limit   => $limit,
 );
+
+my $id = $TicketObj ? "autocomplete-$Name-" . $TicketObj->Id : $Name;
 </%INIT>
 
-<input type="text" name="<%$Name%>" id="<%$Name%>" value="<% $value %>" class="form-control" />
+<input type="text" id="<% $id %>" name="<%$Name%>" value="<% $value %>" class="form-control input-<% $Name %>" />
 <script type="text/javascript">
     jQuery(function() {
         var cache = {};
-        jQuery("#"+<% $Name |n,j%>).autocomplete({
+        jQuery('#<% $id %>').autocomplete({
             minLength: 2,
             source: function(request, response) {
                 if ( request.term in cache ) {

commit 9be3c633472aa15eb1d320eb15d4b469de83db24
Author: michel <michel at bestpractical.com>
Date:   Fri May 1 16:36:03 2020 +0200

    Remove duplicate SLA id in search results when using dropdown.

diff --git a/share/html/Elements/SelectSLA b/share/html/Elements/SelectSLA
index e4759901df..1540ddc62d 100644
--- a/share/html/Elements/SelectSLA
+++ b/share/html/Elements/SelectSLA
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<select name="<%$Name%>" id="<%$Name%>" class="form-control selectpicker">
+<select name="<%$Name%>" class="form-control selectpicker">
 % if ($DefaultValue) {
 <option value=""<% !$Default ? qq[ selected="selected"] : '' |n %>><%$DefaultLabel |n%></option>
 % }

-----------------------------------------------------------------------