[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.0alpha1-376-g505bba52c9

Jim Brandt jbrandt at bestpractical.com
Thu May 7 08:54:46 EDT 2020


The branch, 5.0-trunk has been updated
       via  505bba52c9785f773a73a178dfcec3f5f08ea06b (commit)
       via  df91599f844874846ad45675c01b1eb88fc0fbe5 (commit)
      from  a99f2c05c3e9b10e06d77f4c73f621e4d1ce631a (commit)

Summary of changes:
 lib/RT/Interface/Web.pm | 1 -
 1 file changed, 1 deletion(-)

- Log -----------------------------------------------------------------
commit df91599f844874846ad45675c01b1eb88fc0fbe5
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Wed May 6 18:00:47 2020 -0500

    Avoid triggering RT::System method calls when loading configuration
    
    Extensions with a database step use an _rt_runtime_load function
    to load just RT's configuration without fully initializing
    a running RT. The 'use' on RT::Dashboard added in 1bcdd32 triggers
    AddRight method calls on the uninitialized RT::System object which
    causes 'make initdb' for any extension to fail.

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index 322f70f269..f21eaf42be 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -4683,7 +4683,6 @@ sub UpdateDashboard {
             return ( $ok, $msg ) = $user->SetPreferences( 'HomepageSettings', $data->{panes} );
         }
     } else {
-        use RT::Dashboard;
         my $Dashboard = RT::Dashboard->new( $session{'CurrentUser'} );
         ( $ok, $msg ) = $Dashboard->LoadById($id);
 

commit 505bba52c9785f773a73a178dfcec3f5f08ea06b
Merge: a99f2c05c3 df91599f84
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu May 7 08:47:09 2020 -0400

    Merge branch '5.0/fix-rtir-install' into 5.0-trunk


-----------------------------------------------------------------------


More information about the rt-commit mailing list