[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.0alpha1-401-ge9a902f4ef

[? sunnavy]

The branch, 5.0-trunk has been updated
       via  e9a902f4ef57ed9c6d4b5eef7d32de5acc14dff0 (commit)
      from  6ed7af015a68390634d9eacfca6dc7c186527806 (commit)

Summary of changes:
 lib/RT/Assets.pm       | 2 +-
 lib/RT/Tickets.pm      | 2 +-
 lib/RT/Transactions.pm | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit e9a902f4ef57ed9c6d4b5eef7d32de5acc14dff0
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri May 8 21:22:30 2020 +0800

    Don't cache status nodes for SQL because Lifecycles can be updated via web UI
    
    This could impact performance a little bit, we can come back to this if
    there is a performance issue in the future.

diff --git a/lib/RT/Assets.pm b/lib/RT/Assets.pm
index 9f0617648e..bc43e35d75 100644
--- a/lib/RT/Assets.pm
+++ b/lib/RT/Assets.pm
@@ -1494,7 +1494,7 @@ sub _parser {
         return $text;
     };
 
-    state ( $active_status_node, $inactive_status_node );
+    my ( $active_status_node, $inactive_status_node );
 
     $tree->traverse(
         sub {
diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index 383564e42a..b37a325cd9 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -3035,7 +3035,7 @@ sub _parser {
     );
     die join "; ", map { ref $_ eq 'ARRAY' ? $_->[ 0 ] : $_ } @results if @results;
 
-    state ( $active_status_node, $inactive_status_node );
+    my ( $active_status_node, $inactive_status_node );
 
     my $escape_quotes = sub {
         my $text = shift;
diff --git a/lib/RT/Transactions.pm b/lib/RT/Transactions.pm
index 2b71ade9fb..532221028f 100644
--- a/lib/RT/Transactions.pm
+++ b/lib/RT/Transactions.pm
@@ -902,7 +902,7 @@ sub _parser {
     #   Lifecycle => TicketQueueLifecycle
     #   Status => TicketStatus
 
-    state ( $active_status_node, $inactive_status_node );
+    my ( $active_status_node, $inactive_status_node );
     my $escape_quotes = sub {
         my $text = shift;
         $text =~ s{(['\\])}{\\$1}g;

-----------------------------------------------------------------------