[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.0alpha1-447-g9d2e09cfcb

[? sunnavy]

The branch, 5.0-trunk has been updated
       via  9d2e09cfcb018da0d1f592e1f79e100c3f61aa45 (commit)
       via  e4947baf7cbb1b8aaf82527f6719dbe9d1b9b336 (commit)
       via  425055e8cf5615c0fc210d57e61153504d428145 (commit)
       via  0379119583b52c0098bfabf9bb1c964f86af4af2 (commit)
       via  1f2abd3e83ef7cede1788560cb31140b7792d209 (commit)
       via  30486256d17b0eceac05b0a9487b0604c1a2fae9 (commit)
       via  c3f9963a25d904dfd8d5839132cafb10a5548382 (commit)
       via  b690768413800a19fa60ee951f071742a96ad7b1 (commit)
       via  14306b24f5887f8899dda3d0ae1c1f5a21f6e33c (commit)
      from  a90d185b5680e9331cdcdd6119e359170c4152c2 (commit)

Summary of changes:
 docs/rt_perl.pod                               | 37 ++++++++++++++++++++++++++
 lib/RT/Test.pm                                 | 37 ++++++++++++++++++++++++++
 share/html/Elements/CollectionAsTable/Row      |  7 +++++
 share/html/Elements/ShowTransactionAttachments | 15 +++++++++--
 t/externalstorage/basic.t                      |  2 +-
 t/externalstorage/encoding.t                   |  2 +-
 6 files changed, 96 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit 9d2e09cfcb018da0d1f592e1f79e100c3f61aa45
Merge: a90d185b56 e4947baf7c
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu May 14 23:50:11 2020 +0800

    Merge branch '4.4-trunk' into 5.0-trunk

diff --cc docs/rt_perl.pod
index e624091813,e805197266..5fe0c0ca1f
--- a/docs/rt_perl.pod
+++ b/docs/rt_perl.pod
@@@ -160,4 -160,41 +160,41 @@@ have RT use C<cpanm> to install modules
  
  Then run C<make fixdeps> and let RT install all of its dependencies.
  
+ =head2 Permission Problems with Installed Perl Modules
+ 
+ After running C<make fixdeps> using one of the configurations above, you might see
+ errors like this when starting Apache and trying to access RT:
+ 
 -    Can't locate UNIVERSAL/require.pm in @INC (@INC contains: /opt/rt4/sbin/../local/lib
 -    /opt/rt4/sbin/../lib /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
++    Can't locate UNIVERSAL/require.pm in @INC (@INC contains: /opt/rt5/sbin/../local/lib
++    /opt/rt5/sbin/../lib /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
+     /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
 -    /opt/rt4/sbin/../lib/RT.pm line 60.
 -    BEGIN failed--compilation aborted at /opt/rt4/sbin/../lib/RT.pm line 60.
++    /opt/rt5/sbin/../lib/RT.pm line 60.
++    BEGIN failed--compilation aborted at /opt/rt5/sbin/../lib/RT.pm line 60.
+ 
+ The reported module might be different depending on how the modules were installed.
+ 
+ If you look for the module as a privileged user with a command like
+ C<perldoc UNIVERSAL::require> the module will be found and in one
+ of the paths reported in C<@INC>. So why can't it be located?
+ 
+ One possible cause for this issue is the default umask on the system. Some Linux
+ security hardening guides recommend changing the default umask from a default like
+ C<0002> to a more restrictive value like C<0007>. One result of this is that all
+ of the installed modules will have incorrect permissions for C<everyone>.
+ 
+ Assuming the umask can't be changed, one fix is to update the permissions on the
+ directories where the perl modules were installed. The following works on RHEL 7,
+ update the paths for other perl module locations:
+ 
+     # Fix permissions on /usr/local/share/perl5 recursively
+     > find /usr/local/share/perl5 -type d -exec chmod o+rx {} \;
+ 
+     # Same for /usr/local/lib64/perl5
+     > find /usr/local/lib64/perl5 -type d -exec chmod o+rx {} \;
+ 
+ You might experience the same issue when installing extensions.
+ 
+     # Fix same issue on RT local directories if needed
 -    > find /opt/rt4/local -type d -exec chmod o+rx {} \;
++    > find /opt/rt5/local -type d -exec chmod o+rx {} \;
+ 
  =cut
diff --cc share/html/Elements/CollectionAsTable/Row
index c963d7c087,73bb3c3f7e..02fbde7a57
--- a/share/html/Elements/CollectionAsTable/Row
+++ b/share/html/Elements/CollectionAsTable/Row
@@@ -172,27 -150,16 +172,34 @@@ foreach my $column (@Format) 
          foreach grep $attrs{$_}, qw(align style colspan);
  
      $m->out('>');
 +
 +    if ( $attrs{edit} ) {
 +        $m->out( '<form method="POST" action="' . RT->Config->Get('WebPath') . '/Helpers/TicketUpdate?id=' . $record->id . '" class="editor" autocomplete="off">' );
 +        $m->out( $attrs{edit} );
 +        $m->out( '<span class="cancel text-danger far fa-times-circle" data-toggle="tooltip" data-placement="top" data-original-title="' . loc('Cancel') . '"></span>' );
 +        $m->out( '<span class="submit text-success far fa-check-circle" data-toggle="tooltip" data-placement="top" data-original-title="' . loc('Save') . '"></span>' );
 +        $m->out('<div class="spinner-border spinner-border-sm loading" role="status"><span class="sr-only">Loading...</span></div>');
 +        $m->out('</form>');
 +        $m->out('<div class="value"><span>');
 +    }
 +
      $m->out(@out) if @out;
 +
 +    if ( $attrs{edit} ) {
 +        $m->out(  '</span> <span class="fas fa-pencil-alt edit-icon" data-toggle="tooltip" data-placement="top" data-original-title="'
 +                . loc('Edit')
 +                . '"></span></div>' );
 +    }
 +
      $m->out( '</td>' . "\n" );
  }
+ 
+ # Fill up the last row, like how NEWLINE is handled above
+ while ( $item < $maxitems ) {
+     $m->out(qq{<td class="collection-as-table"> </td>\n});
+     $item++;
+ }
+ 
  $m->out('</tr>');
  $m->out('</tbody>');
  </%init>

-----------------------------------------------------------------------