[Rt-commit] rt branch, 5.0/make-condition-and-action-boxes-on-scrip-basics-page-wider, created. rt-5.0.0-115-g69bf33ad9a
Blaine Motsinger
blaine at bestpractical.com
Fri Nov 13 19:39:09 EST 2020
The branch, 5.0/make-condition-and-action-boxes-on-scrip-basics-page-wider has been created
at 69bf33ad9a5dc325785c1f47eebb579fa9769cc5 (commit)
- Log -----------------------------------------------------------------
commit f705a0f32b0cb7ef9df57840844d7b221e188c3b
Author: Blaine Motsinger <blaine at bestpractical.com>
Date: Fri Oct 2 17:35:33 2020 -0500
Fix input overlap on Scrip Basics
For small window sizes the form inputs overlap the right border of
the titlebox div. Removing width-sm from content_class make the
inputs scale correctly and stay within the border.
diff --git a/share/html/Admin/Scrips/Elements/EditCustomCode b/share/html/Admin/Scrips/Elements/EditCustomCode
index 553e0511df..db0b26cdd2 100644
--- a/share/html/Admin/Scrips/Elements/EditCustomCode
+++ b/share/html/Admin/Scrips/Elements/EditCustomCode
@@ -45,7 +45,7 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<&| /Widgets/TitleBox, title => loc('User Defined conditions and results'), content_class => 'mx-auto width-sm' &>
+<&| /Widgets/TitleBox, title => loc('User Defined conditions and results'), content_class => 'mx-auto' &>
<div class="form-row">
<div class="col-12 comment">
diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index a0f068c8dc..8421f7d609 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -53,7 +53,7 @@
<input type="hidden" class="hidden" name="id" value="<% $id %>" />
<input type="hidden" class="hidden" name="From" value="<% $From || q{} %>" />
-<&| /Widgets/TitleBox, title => loc('Basics'), content_class => 'mx-auto width-sm' &>
+<&| /Widgets/TitleBox, title => loc('Basics'), content_class => 'mx-auto' &>
<& Elements/EditBasics, %ARGS, Scrip => $scrip &>
commit 8faaeb50a6efe9b5bdd02014458bc66752da1580
Author: Blaine Motsinger <blaine at bestpractical.com>
Date: Fri Oct 2 17:59:37 2020 -0500
Make window and inputs wider on Scrip Basics
To make editing code easier on the Scrip Basics page, this commit
changes the max-width to xl (1200px) and makes the inputs and cols
fill as much space as possible. Removing mx-auto from content_class
makes the content fill the total available space within TitleBox.
diff --git a/share/html/Admin/Scrips/Elements/EditCustomCode b/share/html/Admin/Scrips/Elements/EditCustomCode
index db0b26cdd2..ce4b508c7c 100644
--- a/share/html/Admin/Scrips/Elements/EditCustomCode
+++ b/share/html/Admin/Scrips/Elements/EditCustomCode
@@ -45,7 +45,7 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<&| /Widgets/TitleBox, title => loc('User Defined conditions and results'), content_class => 'mx-auto' &>
+<&| /Widgets/TitleBox, title => loc('User Defined conditions and results') &>
<div class="form-row">
<div class="col-12 comment">
diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index 8421f7d609..07e41c3de8 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -49,11 +49,11 @@
<& /Elements/Tabs &>
<& /Elements/ListActions, actions => \@results &>
-<form method="post" action="Modify.html" id="ModifyScrip" name="ModifyScrip" class="mx-auto max-width-lg">
+<form method="post" action="Modify.html" id="ModifyScrip" name="ModifyScrip" class="mx-auto max-width-xl">
<input type="hidden" class="hidden" name="id" value="<% $id %>" />
<input type="hidden" class="hidden" name="From" value="<% $From || q{} %>" />
-<&| /Widgets/TitleBox, title => loc('Basics'), content_class => 'mx-auto' &>
+<&| /Widgets/TitleBox, title => loc('Basics') &>
<& Elements/EditBasics, %ARGS, Scrip => $scrip &>
commit 69bf33ad9a5dc325785c1f47eebb579fa9769cc5
Author: Blaine Motsinger <blaine at bestpractical.com>
Date: Fri Nov 13 18:34:24 2020 -0600
Center content on Scrips Modify
This commit makes the left and right cols smaller to make the
content on the Scrips Modify page more centered.
diff --git a/share/html/Admin/Scrips/Elements/EditBasics b/share/html/Admin/Scrips/Elements/EditBasics
index 678efde633..9392440949 100644
--- a/share/html/Admin/Scrips/Elements/EditBasics
+++ b/share/html/Admin/Scrips/Elements/EditBasics
@@ -46,7 +46,7 @@
%#
%# END BPS TAGGED BLOCK }}}
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
<&|/l&>Description</&>:
</div>
<div class="value col-9">
@@ -55,7 +55,7 @@
</div>
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
<&|/l&>Condition</&>:
</div>
<div class="value col-9">
@@ -64,7 +64,7 @@
</div>
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
<&|/l&>Action</&>:
</div>
<div class="value col-9">
@@ -73,7 +73,7 @@
</div>
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
<&|/l&>Template</&>:
</div>
<div class="value col-9">
diff --git a/share/html/Admin/Scrips/Elements/EditCustomCode b/share/html/Admin/Scrips/Elements/EditCustomCode
index ce4b508c7c..a553acb913 100644
--- a/share/html/Admin/Scrips/Elements/EditCustomCode
+++ b/share/html/Admin/Scrips/Elements/EditCustomCode
@@ -55,7 +55,7 @@
% while ( my ($method, $desc) = splice @list, 0, 2 ) {
<div class="form-row">
- <div class="label col-3 labeltop">
+ <div class="label col-2 labeltop">
<% $desc %>:
</div>
<div class="value col-9">
diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index 07e41c3de8..99f3e78f86 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -59,7 +59,7 @@
% if ( not $disabled ) {
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
<a href="Objects.html?id=<% $id %>"><&|/l&>Applies to</&></a>:
</div>
<div class="value col-9">
@@ -85,7 +85,7 @@
<input type="hidden" class="hidden" name="SetEnabled" value="1" />
<div class="form-row">
- <div class="label col-3">
+ <div class="label col-2">
</div>
<div class="value col-9">
<div class="custom-control custom-checkbox">
-----------------------------------------------------------------------
More information about the rt-commit
mailing list