[Rt-commit] rt branch, 4.4/report-smime-signer-and-issuer-correctly, repushed

[? sunnavy]

The branch 4.4/report-smime-signer-and-issuer-correctly was deleted and repushed:
       was 2934e3b2126c86f6073d4ad4b9d95ec7e3c6db89
       now 1a75ad3d42920d5ea5f1994ded3a666ab62cc377

-:  ------- > 1: 006676e5f0 Report the cert authority in an "assured by ..." clause.
1: 34ae23594d ! 2: 1a75ad3d42 Report the S/MIME signer correctly when there is no EmailAddress
    @@ -1,19 +1,13 @@
     Author: Dianne Skoll <dianne at bestpractical.com>
     
    -    Report the S/MIME signer correctly; also report the cert authority in an "assured by ..." clause.
    +    Report the S/MIME signer correctly when there is no EmailAddress
    +    
    +    There are many cases when a cert doesn't include an email address. On
    +    the other hand, CN is guaranteed to be present
     
     diff --git a/lib/RT/Crypt/SMIME.pm b/lib/RT/Crypt/SMIME.pm
     --- a/lib/RT/Crypt/SMIME.pm
     +++ b/lib/RT/Crypt/SMIME.pm
    -@@
    - 
    -     $res{'status'} = $self->FormatStatus({
    -         Operation => "Verify", Status => "DONE",
    --        Message => "The signature is good, signed by ".$signer->{User}[0]{String}.", trust is ".$signer->{TrustTerse},
    -+        Message => "The signature is good, signed by ".$signer->{User}[0]{String}.", assured by " . $signer->{Issuer}[0]{String} . ", trust is ".$signer->{TrustTerse},
    -         UserString => $signer->{User}[0]{String},
    -         Trust => uc($signer->{TrustTerse}),
    -     });
     @@
                  my $method = $type . "_" . $USER_MAP{$_};
                  $data{$_} = $cert->$method if $cert->can($method);
    @@ -28,4 +22,3 @@
              return \%data;
          };
      
    -
2: 2934e3b212 < -:  ------- Fix unit test to cope with variations in how different versions of OpenSSL print certificates.