[Rt-commit] rt branch, 5.0/lifecycle-ui-mappings-handle-dashes, repushed

[Craig Kaiser]

The branch 5.0/lifecycle-ui-mappings-handle-dashes was deleted and repushed:
       was 1e70d9333584be60c201c011cda83c85b0a0fffd
       now a8e2ae3f4ccc0bd011956077fab147eb65c8be0e

1: 160f41a5e6 = 1: 160f41a5e6 Update instructions for lifecycle mapping page to mention assets
2: 93a6b498e0 = 2: 93a6b498e0 Add general tests for the lifecycle Mappings.html page
3: a8593061a5 = 3: a8593061a5 Update mapping form submission parsing to handle '-' in lifecycle name
4: 1e70d93335 ! 4: a8e2ae3f4c Add test for when lifecycle has '-' in name
    @@ -7,6 +7,37 @@
         one lifecycle named "sales" and one named "sales-engineering" the
         Mappings.html submission will interpret mappings forthe  "sales-engineering"
         lifecycle as a submission for the  "sales" lifecycle.
    +
    +diff --git a/t/lifecycles/types.t b/t/lifecycles/types.t
    +--- a/t/lifecycles/types.t
    ++++ b/t/lifecycles/types.t
    +@@
    + 
    + BEGIN {require  './t/lifecycles/utils.pl'};
    + 
    +-is_deeply( [ RT::Lifecycle->ListAll ], [qw/ approvals default delivery /],
    ++is_deeply( [ RT::Lifecycle->ListAll ], [qw/ approvals default delivery foo sales sales-engineering/],
    +        "Get the list of all lifecycles (implicitly for for tickets)");
    +-is_deeply( [ RT::Lifecycle->ListAll('ticket') ],  [qw/ approvals default delivery /],
    ++is_deeply( [ RT::Lifecycle->ListAll('ticket') ],  [qw/ approvals default delivery foo sales sales-engineering/],
    +        "Get the list of all lifecycles for tickets");
    +-is_deeply( [ RT::Lifecycle->List], [qw/ default delivery /],
    ++is_deeply( [ RT::Lifecycle->List], [qw/ default delivery foo sales sales-engineering /],
    +        "Get the list of lifecycles without approvals (implicitly for for tickets)");
    +-is_deeply( [ RT::Lifecycle->List('ticket') ],  [qw/ default delivery /],
    ++is_deeply( [ RT::Lifecycle->List('ticket') ],  [qw/ default delivery foo sales sales-engineering/],
    +        "Get the list of lifecycles without approvals for tickets");
    + is_deeply( [ RT::Lifecycle->List('racecar') ], [qw/ racing /],
    +        "Get the list of lifecycles for other types");
    +@@
    + isa_ok( $tickets, "RT::Lifecycle::Ticket", "Is the right subclass" );
    + is_deeply( [ sort $tickets->Valid ],
    +            [ sort qw(new open stalled resolved rejected deleted ordered),
    +-             'on way', 'delayed', 'delivered' ],
    ++             'on way', 'delayed', 'delivered', 'sales', 'engineering', 'initial', 'active', 'inactive'],
    +            "Only gets ticket statuses" );
    + 
    + 
     
     diff --git a/t/lifecycles/utils.pl b/t/lifecycles/utils.pl
     --- a/t/lifecycles/utils.pl