[Rt-commit] rt branch, 5.0/fix-lifecycle-mappings-redirect-code, created. rt-5.0.0-119-gd152511dd7

[Craig Kaiser]

The branch, 5.0/fix-lifecycle-mappings-redirect-code has been created
        at  d152511dd7158d80bb40cdbec170aa10e88b7ae4 (commit)

- Log -----------------------------------------------------------------
commit d152511dd7158d80bb40cdbec170aa10e88b7ae4
Author: craig kaiser <craig at bestpractical.com>
Date:   Wed Nov 18 15:15:27 2020 -0500

    Move 'MaybeRedirectForResults' code after mapping updates

diff --git a/share/html/Admin/Lifecycles/Mappings.html b/share/html/Admin/Lifecycles/Mappings.html
index d487fedc3a..1540ce0961 100644
--- a/share/html/Admin/Lifecycles/Mappings.html
+++ b/share/html/Admin/Lifecycles/Mappings.html
@@ -116,12 +116,6 @@ my @MyStatuses = $LifecycleObj->Valid;
 
 $title = loc("Lifecycle [_1] Mappings", $LifecycleObj->Name);
 
-# This code does automatic redirection if any updates happen.
-MaybeRedirectForResults(
-    Actions   => \@results,
-    Arguments => { Name => $LifecycleObj->Name, Type => $LifecycleObj->Type },
-);
-
 my @lifecycle_names = grep { $_ ne 'approvals' } RT::Lifecycle->ListAll($Type);
 
 if ($Update) {
@@ -139,6 +133,12 @@ if ($Update) {
         Maps         => \%maps,
     );
     push @results, $msg;
+
+    # This code does automatic redirection if any updates happen.
+    MaybeRedirectForResults(
+        Actions   => \@results,
+        Arguments => { Name => $LifecycleObj->Name, Type => $LifecycleObj->Type },
+    );
 }
 
 my @lifecycles = map { RT::Lifecycle->Load(Name => $_, Type => $Type) }

-----------------------------------------------------------------------