[Rt-commit] rt branch, 4.4/set-gnupg-path-in-constructor, created. rt-4.4.4-137-gd9a22cfe0b

[Dianne Skoll]

The branch, 4.4/set-gnupg-path-in-constructor has been created
        at  d9a22cfe0b539764a3fdd2d1ff41374745c0e65d (commit)

- Log -----------------------------------------------------------------
commit d9a22cfe0b539764a3fdd2d1ff41374745c0e65d
Author: Dianne Skoll <dianne at bestpractical.com>
Date:   Tue Sep 8 16:16:44 2020 -0400

    Set path to GnuPG binary in GnuPG::Interface constructor.
    
    Old versions of GnuPG::Interface would check the GnuPG version in the
    constructor.  If the path is not supplied in the constructor, it would
    attempt to execute the default gpg binary and potentially error out.
    
    While there is a fix for the problem in GnuPG::Interface, this change
    should let RT work properly with unfixed versions of GnuPG::Interface
    
    Fixes: I#36623

diff --git a/lib/RT/Crypt/GnuPG.pm b/lib/RT/Crypt/GnuPG.pm
index 8ebfbf938e..988af8741a 100644
--- a/lib/RT/Crypt/GnuPG.pm
+++ b/lib/RT/Crypt/GnuPG.pm
@@ -333,8 +333,7 @@ sub CallGnuPG {
         %GnuPGOptions,
         %{ $args{Options} || {} },
     );
-    my $gnupg = GnuPG::Interface->new;
-    $gnupg->call( $self->GnuPGPath );
+    my $gnupg = GnuPG::Interface->new( call => $self->GnuPGPath );
     $gnupg->options->hash_init(
         _PrepareGnuPGOptions( %opt ),
     );
@@ -1848,7 +1847,6 @@ sub GnuPGPath {
 
 sub Probe {
     my $self = shift;
-    my $gnupg = GnuPG::Interface->new;
 
     my $bin = $self->GnuPGPath();
     unless ($bin) {
@@ -1878,7 +1876,7 @@ sub Probe {
         $self->GnuPGPath( $bin = $path );
     }
 
-    $gnupg->call( $bin );
+    my $gnupg = GnuPG::Interface->new( call => $bin );
     $gnupg->options->hash_init(
         _PrepareGnuPGOptions( RT->Config->Get('GnuPGOptions') )
     );

-----------------------------------------------------------------------