[Rt-commit] rt branch, 5.0/lifecycle-ui-mappings-fixes, created. rt-5.0.0-63-ge5372d2403

[Craig Kaiser]

The branch, 5.0/lifecycle-ui-mappings-fixes has been created
        at  e5372d2403d576db84cfcd65241d15f2a8fb3595 (commit)

- Log -----------------------------------------------------------------
commit 5b45399f094ee19f2e35dfc75661b0afdcc18aa8
Author: craig kaiser <craig at bestpractical.com>
Date:   Wed Oct 28 14:35:42 2020 -0400

    Limit mappings status dropdowns to respective lifecycle
    
    Previously all statuses were available to choose from when really we
    should only be able to choose from the valid statuses of the "To"
    lifecycle we are mapping to.

diff --git a/share/html/Admin/Lifecycles/Mappings.html b/share/html/Admin/Lifecycles/Mappings.html
index 0da577941b..8aa8c21530 100644
--- a/share/html/Admin/Lifecycles/Mappings.html
+++ b/share/html/Admin/Lifecycles/Mappings.html
@@ -63,7 +63,6 @@
 % my $FromMapping = $Other->MoveMap($LifecycleObj);
 % my $ToMapping = $LifecycleObj->MoveMap($Other);
 % my @OtherStatuses = $Other->Valid;
-
 <&| /Widgets/TitleBox, title => $Other->Name &>
   <div class="form-row">
     <div class="col-6">
@@ -74,7 +73,7 @@
           <% $OtherStatus %>:
         </div>
         <div class="col-8 value">
-          <& /Elements/SelectStatus, Statuses => \@MyStatuses, Default => $FromMapping->{$OtherStatus}, Name => 'map-' . $Other->Name . '-' . $OtherStatus . '--' . $LifecycleObj->Name&>
+          <& /Elements/SelectStatus, Lifecycles => [$LifecycleObj], Default => $FromMapping->{$OtherStatus}, Name => 'map-' . $Other->Name . '-' . $OtherStatus . '--' . $LifecycleObj->Name &>
         </div>
       </div>
 % }
@@ -88,7 +87,7 @@
           <% $MyStatus %>:
         </div>
         <div class="col-8 value">
-          <& /Elements/SelectStatus, Statuses => \@OtherStatuses, Default => $ToMapping->{$MyStatus}, Name => 'map-' . $LifecycleObj->Name . '-' . $MyStatus . '--' . $Other->Name &>
+          <& /Elements/SelectStatus, Lifecycles => [$Other], Default => $ToMapping->{$MyStatus}, Name => 'map-' . $LifecycleObj->Name . '-' . $MyStatus . '--' . $Other->Name &>
         </div>
       </div>
 % }

commit e5372d2403d576db84cfcd65241d15f2a8fb3595
Author: craig kaiser <craig at bestpractical.com>
Date:   Wed Oct 28 14:50:18 2020 -0400

    Update instructions for lifecycle mapping page to mention assets

diff --git a/share/html/Admin/Lifecycles/Mappings.html b/share/html/Admin/Lifecycles/Mappings.html
index 8aa8c21530..31315c08b9 100644
--- a/share/html/Admin/Lifecycles/Mappings.html
+++ b/share/html/Admin/Lifecycles/Mappings.html
@@ -50,7 +50,7 @@
 <& /Elements/ListActions, actions => \@results &>
 <div class="form-row">
   <div class="col-12">
-    <p><&|/l&>If a ticket is moved from one queue or catalog to another, these mappings define how statuses should be updated.</&></p>
+    <p><&|/l&>If a ticket or asset is moved from one queue or catalog to another, these mappings define how statuses should be updated.</&></p>
   </div>
 </div>
 

-----------------------------------------------------------------------