[Rt-commit] rt branch, 5.0/more-dark-theme-fixes, created. rt-5.0.0-9-g4ac82ce962

Blaine Motsinger blaine at bestpractical.com
Tue Sep 1 19:35:11 EDT 2020


The branch, 5.0/more-dark-theme-fixes has been created
        at  4ac82ce9622da2641096fa0123a5b2aa28ad5315 (commit)

- Log -----------------------------------------------------------------
commit c83fbbec42b05dab164f1bf16de621ec48b1ee94
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Tue Sep 1 15:13:07 2020 -0500

    Fix dark theme pagenum background color overlap

diff --git a/share/static/css/elevator-dark/main.css b/share/static/css/elevator-dark/main.css
index 1d361e6fe0..064235a2f9 100644
--- a/share/static/css/elevator-dark/main.css
+++ b/share/static/css/elevator-dark/main.css
@@ -377,3 +377,7 @@
     margin-bottom: 1px;
     line-height: 24px;
 }
+
+.darkmode div.paging span.pagenum span.currentpage, .darkmode div.paging span.pagenum a {
+    background-color: transparent !important;
+}

commit 4ac82ce9622da2641096fa0123a5b2aa28ad5315
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Tue Sep 1 18:29:07 2020 -0500

    Fix dark theme action-private color in RichText editor
    
    The action-comment selector was not the correct target, so wasn't
    applying the dark text color on comment, making it hard to read.

diff --git a/share/static/RichText/contents-dark.css b/share/static/RichText/contents-dark.css
index 00e5cce596..9d4bde0e41 100644
--- a/share/static/RichText/contents-dark.css
+++ b/share/static/RichText/contents-dark.css
@@ -4,7 +4,7 @@
 }
 
 .cke_editable.action-response,
-.cke_editable.action-comment {
+.cke_editable.action-private {
     color: #333 !important;
 }
 
diff --git a/share/static/js/util.js b/share/static/js/util.js
index 34dd5ec92f..5538626be1 100644
--- a/share/static/js/util.js
+++ b/share/static/js/util.js
@@ -727,7 +727,7 @@ jQuery(function() {
     if ( RT.Config.WebDefaultStylesheet.match(/dark/) ) {
 
         // Add action type into iframe to customize default font color
-        jQuery(['action-response', 'action-comment']).each(function(index, class_name) {
+        jQuery(['action-response', 'action-private']).each(function(index, class_name) {
             jQuery('.' + class_name).on('DOMNodeInserted', 'iframe', function(e) {
                 setTimeout(function() {
                     jQuery(e.target).contents().find('.cke_editable').addClass(class_name);

-----------------------------------------------------------------------


More information about the rt-commit mailing list