[Rt-commit] rt branch, 5.0/fix-delete-group-member-input, created. rt-5.0.0-22-gf5f5f92789

? sunnavy sunnavy at bestpractical.com
Tue Sep 8 10:39:24 EDT 2020


The branch, 5.0/fix-delete-group-member-input has been created
        at  f5f5f927897e04323494e060e635c3bc2f7143f2 (commit)

- Log -----------------------------------------------------------------
commit f5f5f927897e04323494e060e635c3bc2f7143f2
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Sep 8 22:21:35 2020 +0800

    Fix the input name to delete group members on group admin page
    
    Note that $id already has "DeleteMember-" prefix.
    
    The issue was introduced in 43706267d3, when we migrated to RT 5 themes.

diff --git a/share/html/Admin/Groups/Members.html b/share/html/Admin/Groups/Members.html
index f7ae2f198f..007bb31b60 100644
--- a/share/html/Admin/Groups/Members.html
+++ b/share/html/Admin/Groups/Members.html
@@ -90,7 +90,7 @@ my @users = map {$_->[1]}
 % my $id= 'DeleteMember-' .  $member->MemberId;
       <li class="list-group-item">
         <div class="custom-control custom-checkbox">
-          <input type="checkbox" class="checkbox custom-control-input" id="<% $id%>" name="DeleteMember-<% $id%>" value="1" />
+          <input type="checkbox" class="checkbox custom-control-input" id="<% $id%>" name="<% $id %>" value="1" />
           <label class="custom-control-label" for="<% $id %>">
             <a href="<% RT->Config->Get('WebPath') %>/Admin/Groups/Modify.html?id=<% $member->MemberObj->Object->id %>"><% $member->MemberObj->Object->Name %></a>
           </label>

-----------------------------------------------------------------------


More information about the rt-commit mailing list