[Rt-commit] rt branch, 5.0/require-article-name, repushed
Aaron Trevena
ast at bestpractical.com
Thu Sep 10 14:06:58 EDT 2020
The branch 5.0/require-article-name was deleted and repushed:
was 4b90b6fb21c338b0608b493823b61cf5182522d8
now 7c2352d91b2c55f2029b9a885f652ae8ebce6ca9
1: 73e7a43000 ! 1: 5b3f55eedf Require Name field when creating or editing Article
@@ -5,8 +5,7 @@
Articles with empty name fields cause a problem with re-submission
and duplicate content when creating a ticket with that article.
- Make Name a required field when creating or editing articles and
- update article extraction from tickets to set required name field.
+ Make Name a required field when creating or editing articles.
diff --git a/lib/RT/Article.pm b/lib/RT/Article.pm
--- a/lib/RT/Article.pm
@@ -22,15 +21,3 @@
unless $self->ValidateName( $args{'Name'} );
-diff --git a/share/html/Articles/Article/ExtractFromTicket.html b/share/html/Articles/Article/ExtractFromTicket.html
---- a/share/html/Articles/Article/ExtractFromTicket.html
-+++ b/share/html/Articles/Article/ExtractFromTicket.html
-@@
- <form action="Edit.html" method="post">
- <input type="hidden" name="Class" value="<%$ARGS{'Class'}%>" />
- <input type="hidden" name="Summary" value="<%$ticket->Subject%>" />
-+<input type="hidden" name="Name" value="<%$ticket->Subject%>" />
- % for (@Topics) {
- <input type="hidden" name="Topics" value="<% $_ %>" />
- % }
-
2: 4b90b6fb21 ! 2: 7c2352d91b Update tests to provide required name field for articles
@@ -47,6 +47,19 @@
ok($art->URIObj);
+diff --git a/t/articles/interface.t b/t/articles/interface.t
+--- a/t/articles/interface.t
++++ b/t/articles/interface.t
+@@
+ $m->set_visible([option => $answerCF->Name]);
+ $m->click();
+ $m->title_like(qr/Create a new article/, "got edit page from extraction");
+-$m->submit_form(form_name => 'EditArticle');
++$m->submit_form(form_name => 'EditArticle', fields => { Name => 'more testing' });
+ $m->title_like(qr/Modify article/);
+ $m->follow_link_ok( { text => 'Display' }, '-> Display' );
+ $m->content_like(qr/Africa/, "Article content exist");
+
diff --git a/t/web/command_line_link_to_articles.t b/t/web/command_line_link_to_articles.t
--- a/t/web/command_line_link_to_articles.t
+++ b/t/web/command_line_link_to_articles.t
More information about the rt-commit
mailing list