[Rt-commit] rt branch, 5.0/self-service-remove-duplicate-page-layout, created. rt-5.0.1-237-g912db5f24e

? sunnavy sunnavy at bestpractical.com
Tue Apr 20 16:31:00 EDT 2021


The branch, 5.0/self-service-remove-duplicate-page-layout has been created
        at  912db5f24e82ba042290f8ca4744a8864659a474 (commit)

- Log -----------------------------------------------------------------
commit 912db5f24e82ba042290f8ca4744a8864659a474
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Apr 21 04:17:36 2021 +0800

    No need to explicitly call PageLayout as it's included already
    
    The above "/SelfService/Elements/Header" calls "/Elements/Tabs", which
    calls "/Elements/PageLayout".
    
    This commit fixes the duplicate issue of generated html(e.g. div#body)
    for SelfService homepage(if $SelfServiceUseDashboard is not enabled)

diff --git a/share/html/SelfService/Open.html b/share/html/SelfService/Open.html
index 63a11342e5..1216dda4e8 100644
--- a/share/html/SelfService/Open.html
+++ b/share/html/SelfService/Open.html
@@ -46,7 +46,6 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <& /SelfService/Elements/Header, Title => loc('Open tickets') &>
-<& /Elements/PageLayout, show_menu => 0 &>
 % $m->callback(CallbackName => 'BeforeMyRequests', ARGSRef => \%ARGS, Page => $Page);
 
 <& /SelfService/Elements/MyRequests,

-----------------------------------------------------------------------


More information about the rt-commit mailing list