[Rt-commit] rtir branch 4.0/rt445-fixes created. 4.0.1-4-g4623c669

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rtir".

The branch, 4.0/rt445-fixes has been created
        at  4623c669829f860b305452c2fe3f01ab42258a3d (commit)

- Log -----------------------------------------------------------------
commit 4623c669829f860b305452c2fe3f01ab42258a3d
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Mon Aug 16 18:02:31 2021 -0500

    Fix ticket search value quoting
    
    RT 4.4.5 (commit 528277f) added support for columns as values in
    ticket search.  When parsing the submitted query, QueryBuilder now
    interprets a bareword value to mean column.
    
    Because of this change, RTIR now must quote values that shouldn't
    map to a column name, such the value for Queue.

diff --git a/html/RTIR/Search/Elements/ProcessQuery b/html/RTIR/Search/Elements/ProcessQuery
index b32d562c..f9389103 100644
--- a/html/RTIR/Search/Elements/ProcessQuery
+++ b/html/RTIR/Search/Elements/ProcessQuery
@@ -169,6 +169,7 @@ foreach my $arg ( keys %ARGS ) {
             Key   => $keyword,
             Op    => $op,
             Value => $value,
+            QuoteValue => $value =~ /^[+-]?[0-9]+$/ ? 0 : 1,
         };
 
         push @new_values, RT::Interface::Web::QueryBuilder::Tree->new($clause);

commit eecde7a57a1fe320fed5ecaccf9dd6c22c996d96
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Sun Aug 15 11:51:31 2021 -0500

    Allow more whitespace in has_watchers regex

diff --git a/lib/RT/IR/Test/Web.pm b/lib/RT/IR/Test/Web.pm
index 2d1635ab..266d71a5 100644
--- a/lib/RT/IR/Test/Web.pm
+++ b/lib/RT/IR/Test/Web.pm
@@ -310,7 +310,7 @@ sub has_watchers {
     $self->display_ticket($id);
 
     return $self->content_like(
-qr{<td class="labeltop">Correspondents:</td>\s*<td class="value">\s*<span class="user" data-user-id="\d+">\s*<a href="/User/Summary\.html\?id=\d+">\s*([@\w\.&;]+)\s*</a></span>}ms,
+qr{<td class="labeltop">Correspondents:</td>\s*<td class="value">\s*<span class="user" data-user-id="\d+">\s*<a\s+href="/User/Summary\.html\?id=\d+">\s*([@\w\.&;]+)\s*</a></span>}ms,
         "Found $type",
     );
 }

-----------------------------------------------------------------------


hooks/post-receive
-- 
rtir