[Rt-commit] rt branch, 5.0/fix-old-attach-layout, created. rt-5.0.1-13-gb6731467b0

[Blaine Motsinger]

The branch, 5.0/fix-old-attach-layout has been created
        at  b6731467b0ca6efe611e66a5640c2f5e215940c7 (commit)

- Log -----------------------------------------------------------------
commit 361c62a8162e1513656c4646452938728251d50f
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Fri Feb 12 19:28:46 2021 -0600

    Fix AddAttachment inputs for old-attach layout
    
    This commit fixes the old-attach form by fixing the html structure,
    adding bootstrap divs, and restoring the missing hidden input.
    
    Fixes: I#37056

diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index 352ca15ec3..892800a844 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -162,11 +162,19 @@ jQuery( function() {
 });
 </script>
         <div class="hidden old-attach">
-          <div class="custom-file">
-            <input type="file" id="Attach" name="Attach" class="custom-file-input" />
-            <label class="custom-file-label" for="Attach">
-              <input type="submit" class="button" name="AddMoreAttach" value="<&|/l&>Add More Files</&>" />
-            </label>
+          <div class="form-row">
+            <div class="col-12">
+              <div class="custom-file">
+                <input type="file" id="Attach" name="Attach" class="custom-file-input" />
+                <label class="custom-file-label" for="Attach"></label>
+              </div>
+            </div>
+          </div>
+          <div class="form-row">
+            <div class="col-12">
+              <input type="submit" class="button btn btn-primary form-control" name="AddMoreAttach" value="<&|/l&>Add More Files</&>" />
+              <input type="hidden" class="hidden" name="UpdateAttach" value="1" />
+            </div>
           </div>
         </div>
 </div>

commit b6731467b0ca6efe611e66a5640c2f5e215940c7
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Thu Feb 18 17:24:04 2021 -0600

    Add label text to old-attach form for accessiblity

diff --git a/share/html/Ticket/Elements/AddAttachments b/share/html/Ticket/Elements/AddAttachments
index 892800a844..de795511dd 100644
--- a/share/html/Ticket/Elements/AddAttachments
+++ b/share/html/Ticket/Elements/AddAttachments
@@ -166,7 +166,7 @@ jQuery( function() {
             <div class="col-12">
               <div class="custom-file">
                 <input type="file" id="Attach" name="Attach" class="custom-file-input" />
-                <label class="custom-file-label" for="Attach"></label>
+                <label class="custom-file-label" for="Attach">Choose file</label>
               </div>
             </div>
           </div>

-----------------------------------------------------------------------