[Rt-commit] rtir branch, 5.0/allow-inline-edit-on-ticket-display, repushed

[Craig Kaiser]

The branch 5.0/allow-inline-edit-on-ticket-display was deleted and repushed:
       was fa3c3d164e84ff88c4db8b859c6419ca5cbc0907
       now f1fca5b8dea587e677cf26711cf9bd62ec2654e7

1: fffa4158 ! 1: 1e2fe5f7 Add inline edit to RTIR Display.html page
    @@ -311,7 +311,7 @@
          $QueueObj->Load($Queue) || Abort(loc("Queue could not be loaded."));
      }
      
    -+my $edit_label = $m->interp->apply_escapes( loc("Edit"), 'h' );
    ++my $edit_label   = $m->interp->apply_escapes( loc("Edit"), 'h' );
     +my $cancel_label = $m->interp->apply_escapes( loc("Cancel"), 'h' );
     +
     +my %inline_edit_behavior;
    @@ -331,7 +331,7 @@
      
          push @results, ProcessTicketBasics(  TicketObj => $Ticket, ARGSRef => \%ARGS );
     +    push @results, ProcessObjectCustomFieldUpdates( ARGSRef => \%ARGS, Object => $Ticket );
    -+    push @results, ProcessTicketWatchers(ARGSRef => \%ARGS, TicketObj => $Ticket );
    ++    push @results, ProcessTicketWatchers( ARGSRef => \%ARGS, TicketObj => $Ticket );
      
          my $strict_acl = RT->Config->Set( StrictLinkACL => 0 );
          push @results, ProcessTicketLinks(   TicketObj => $Ticket, ARGSRef => \%ARGS );
2: 874443e6 ! 2: 1b5415f9 Add inline edit to Incident/Display.html page
    @@ -18,7 +18,7 @@
     +        . '<a class="inline-edit-toggle cancel hidden" href="#">'
     +        . qq{<span class="fas fa-times icon-bordered fa-2x" alt="$cancel_label" data-toggle="tooltip" data-placement="top" data-original-title="$cancel_label"></span>}
     +        . '</a>';
    -+    my $modify_basics = sprintf( $modify_inline, $m->interp->apply_escapes( $modify_url, 'h' ) );
    ++    my $modify_basics   = sprintf( $modify_inline, $m->interp->apply_escapes( $modify_url, 'h' ) );
     +    my $modify_behavior = $InlineEdit ? ($inline_edit_behavior{Basics} || $inline_edit_behavior{_default} || 'link') : 'hide';
     +</%PERL>
     +
    @@ -207,19 +207,10 @@
      
      
     @@
    -     my $QueueObj = RT::Queue->new( $session{'CurrentUser'} );
    -     $QueueObj->Load( $Queue ) || Abort(loc("Couldn't load queue."));
    -     unless( RT::IR->IsIncidentQueue($QueueObj) ) {
    --        return $m->comp('/RTIR/Display.html', %ARGS );
    -+        return $m->comp('/RTIR/Incident/Display.html', %ARGS );
    -     }
    -     ($TicketObj, @results) = CreateTicket( %ARGS );
    -     $new_ticket = 1;
    -@@
          $TicketObj = LoadTicket( $id );
      }
      
    -+my $edit_label = $m->interp->apply_escapes( loc("Edit"), 'h' );
    ++my $edit_label   = $m->interp->apply_escapes( loc("Edit"), 'h' );
     +my $cancel_label = $m->interp->apply_escapes( loc("Cancel"), 'h' );
     +
     +my %inline_edit_behavior;
    @@ -232,14 +223,6 @@
      $m->callback(CallbackName => 'ProcessArguments', 
                  Ticket => $TicketObj,
                  ARGSRef => \%ARGS,  
    -             Actions => \@results);
    - 
    - unless( RT::IR->IsIncidentQueue($TicketObj->QueueObj) ) {
    --    return $m->comp('/RTIR/Display.html', %ARGS );
    -+    return $m->comp('/RTIR/Incident/Display.html', %ARGS );
    - }
    - $ARGS{'id'} = $id = $TicketObj->Id;
    - 
     @@
      
      unless( $new_ticket ) {
3: fa3c3d16 = 3: f1fca5b8 Add ARG for /RTIR/Elements/ShowIncidents to add classes when in a form