[Rt-commit] rt branch, 4.4/disabled-cf-sortorder, repushed

[? sunnavy]

The branch 4.4/disabled-cf-sortorder was deleted and repushed:
       was 48d30c08367b88c78f9e1b97d2a7b955ba69ff33
       now 36d726805f9139228a02f5e2ad542fb20367427d

1: 64addf7b62 ! 1: 2f4fb5a400 Test showing incorrect sort order on re-enabled CF
    @@ -6,8 +6,8 @@
     --- a/t/api/customfield.t
     +++ b/t/api/customfield.t
     @@
    - $cf->LoadByName(Name => 'TestingCF', Queue => 1, IncludeDisabled => 0 );
    - ok( ! $cf->id, "Doesn't find it if IncludeDisabled => 0" );
    + is( $cf_values->Count, 2, 'Found 2 values' );
    + is( $ticket->CustomFieldValuesAsString( $cf, Separator => ', ' ), 'forth value, fifth value', 'Current cf contents' );
      
     +$cf = RT::CustomField->new( RT->SystemUser );
     +$cf->LoadByName(Name => 'TestingCF', Queue => 1, IncludeDisabled => 1 );
    @@ -65,6 +65,6 @@
     +( $ok, $msg ) = $ocf->LoadByCols( CustomField => $cf->id, ObjectId => 0 );
     +ok( $ok, "Found OCF for " . $cf->Name );
     +is( $ocf->SortOrder, 5, 'Sort order is 5, CF moved to bottom of list on re-enable');
    - 
    ++
      done_testing;
     
2: 9e4e31abcc = 2: bb33cfd698 Reset ObjectCustomField sort order when re-enabling a Custom Field
3: 48d30c0836 ! 3: 36d726805f Update ObjectCustomField sort order only if necessary on re-enable
    @@ -1,6 +1,6 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    update ObjectCustomField sort order only if necessary when re-enabling a Custom Field
    +    Update ObjectCustomField sort order only if necessary on re-enable
         
         If an ObjectCustomField object is already the last one and the sort
         order is not shared, then there is no need to update.