[Rt-commit] rtir branch, 5.0/fix-edit-search-query-on-merge-pages, created. 5.0.0-24-g4fa8817e

[? sunnavy]

The branch, 5.0/fix-edit-search-query-on-merge-pages has been created
        at  4fa8817ec48b44ea330fa5dd2b13cfddf3bc21ca (commit)

- Log -----------------------------------------------------------------
commit 4fa8817ec48b44ea330fa5dd2b13cfddf3bc21ca
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Jan 9 04:59:13 2021 +0800

    Fix Query of "Edit Search" menu on merge pages
    
    Earlier $search_arguments->() already gets the correct Query from
    "SearchArgs" param of "/Elements/Tabs", so there is no need to
    re-generate, not mentioning that the generation is wrong.
    
    This commit fixes the issue that Query param of "Edit Search" on Merge
    pages was empty, which was introduced when we migrated to RT search
    pages in 5.0.

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index 4c8bc5db..954c06d5 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -425,10 +425,6 @@ if ( $request_path =~ m{(?:$re_rtir_path)(?:$re_rtir_types/)?(Display|Edit|Updat
     my %args = (
         $search_arguments->(),
         id    => $id,
-        Query => RT::IR->Query(
-            Lifecycle => $ARGS{'Lifecycle'},
-            Exclude   => $ARGS{'id'},
-        ),
         ExtraQueryParams => [ 'RTIR', 'id' ],
         RTIR             => 1,
     );

-----------------------------------------------------------------------