[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.1-444-g24075ebf30

? sunnavy sunnavy at bestpractical.com
Fri Jun 11 14:50:51 EDT 2021


The branch, 5.0-trunk has been updated
       via  24075ebf305e941a81f3fe557ab0b502a1b75d2c (commit)
       via  e85402958b971af96e7883d5d377ee1cf241560f (commit)
      from  c572ca6beb9950ae209d89ec5e326f0356f4ce23 (commit)

Summary of changes:
 lib/RT/Transaction.pm                        | 2 +-
 share/html/Articles/Elements/NewestArticles  | 2 +-
 share/html/Articles/Elements/UpdatedArticles | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit e85402958b971af96e7883d5d377ee1cf241560f
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jun 9 04:37:56 2021 +0800

    Remove the extra quote from transaction description of DeleteConfig

diff --git a/lib/RT/Transaction.pm b/lib/RT/Transaction.pm
index 9032642f27..e6a5746ce0 100644
--- a/lib/RT/Transaction.pm
+++ b/lib/RT/Transaction.pm
@@ -1437,7 +1437,7 @@ sub _CanonicalizeRoleName {
     },
     DeleteConfig => sub  {
         my $self = shift;
-        return ('[_1] deleted"', $self->Field); #loc()
+        return ('[_1] deleted', $self->Field); #loc()
     }
 );
 

commit 24075ebf305e941a81f3fe557ab0b502a1b75d2c
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jun 9 04:40:20 2021 +0800

    Let article summary take the whole width in article list
    
    Previously we set it to 11 cols with offset 1 which didn't work as
    expected because "col-offset-1" is obsolete(should be "offset-1"), so it
    behaved just like "col-11".
    
    As summary font is small and not bold, it's distinguishable enough even
    without an extra offset, here we simply let it take the whole width.

diff --git a/share/html/Articles/Elements/NewestArticles b/share/html/Articles/Elements/NewestArticles
index 49453641db..624b6ef914 100644
--- a/share/html/Articles/Elements/NewestArticles
+++ b/share/html/Articles/Elements/NewestArticles
@@ -78,7 +78,7 @@
   </div>
 </div>
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-summary">
-  <div class="col-11 col-offset-1">
+  <div class="col-12">
     <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
 </div>
diff --git a/share/html/Articles/Elements/UpdatedArticles b/share/html/Articles/Elements/UpdatedArticles
index a44d57cd7e..8328114b23 100644
--- a/share/html/Articles/Elements/UpdatedArticles
+++ b/share/html/Articles/Elements/UpdatedArticles
@@ -80,7 +80,7 @@
 </div>
 
 <div class="<% $i%2 ? 'oddline' : 'evenline'%> form-row article-summary">
-  <div class="col-11 col-offset-1">
+  <div class="col-12">
     <span class="current-value"><small><%$Article->Summary || loc('(no Summary)')%></small></span>
   </div>
 </div>

-----------------------------------------------------------------------


More information about the rt-commit mailing list