[Rt-commit] rtir branch, 4.0/fix-recipient-squelching-on-update-2, created. 4.0.1-3-g4569b16c

? sunnavy sunnavy at bestpractical.com
Fri Mar 5 17:12:05 EST 2021


The branch, 4.0/fix-recipient-squelching-on-update-2 has been created
        at  4569b16c77b575e140cb89be4975fd1dc87139a9 (commit)

- Log -----------------------------------------------------------------
commit 4569b16c77b575e140cb89be4975fd1dc87139a9
Author: Dianne Skoll <dianne at bestpractical.com>
Date:   Wed Dec 9 13:53:48 2020 -0500

    Fix squelching functionality on update page
    
    We need to keep track of submitted squelching info, so the state is not
    lost when user submits the form to refresh, e.g. via "Select an Article
    to include".
    
    Note that RT's update page calls both "ShowSimplifiedRecipients" and
    "PreviewScrips". To avoid duplication, "ShowSimplifiedRecipients"
    renders the hidden input only if current user lacks ShowOutgoingEmail
    right by default. As we don't use "PreviewScrips" in RTIR, we need to
    force render the input in "ShowSimplifiedRecipients"

diff --git a/html/RTIR/Update.html b/html/RTIR/Update.html
index 83068b6b..0f63336d 100644
--- a/html/RTIR/Update.html
+++ b/html/RTIR/Update.html
@@ -120,11 +120,15 @@
 <div id="ticket-update-message">
 
 <&|/Widgets/TitleBox, title => loc('Recipients'), id => 'recipients' &>
+% for my $address ( grep {defined} @TxnSendMailTo ) {
+    <input type="hidden" name="TxnSendMailTo" value="<% $address %>" />
+% }
+  <input type="hidden" name="TxnRecipients" value="<% $TxnRecipients %>" />
 </&>
 <script type="text/javascript">
 jQuery( function() {
    var updateScrips = function() {
-       jQuery('#recipients div.titlebox-content').load( '<% RT->Config->Get('WebPath')%>/Helpers/ShowSimplifiedRecipients',
+       jQuery('#recipients div.titlebox-content').load( '<% RT->Config->Get('WebPath')%>/Helpers/ShowSimplifiedRecipients?RenderTxnRecipientsInput=1',
            jQuery('form[name=TicketUpdate]').serialize(),
            function() {
                var txn_send_field = jQuery("#recipients input[name=TxnSendMailTo]");

-----------------------------------------------------------------------


More information about the rt-commit mailing list