[Rt-commit] rt branch, 4.4/custom-role-not-update-groups, repushed

? sunnavy sunnavy at bestpractical.com
Mon Mar 29 16:11:38 EDT 2021


The branch 4.4/custom-role-not-update-groups was deleted and repushed:
       was 99bad53d76ea19db853d0ce047db0dea46665c18
       now b6f9a561c4a6d27374ef08f24b893fd3c99c59cc

1: 5f949ae898 ! 1: 14054242e1 Don't enable/disable related groups when enabling/disabling custom roles
    @@ -1,6 +1,6 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    Don't enable/disable related groups when updating custom roles
    +    Don't enable/disable related groups when enabling/disabling custom roles
         
         This is for performance: as each ticket has a correponding group for a
         custom role, it could be time consuming when there are many tickets
2: 99bad53d76 ! 2: b6f9a561c4 Enable previously disabled custom role groups
    @@ -2,16 +2,17 @@
     
         Enable previously disabled custom role groups
         
    -    As we don't enable/disable them automatically when updating custom
    -    roles, we need to make sure they are all enabled.
    +    As we don't enable/disable corresponding groups automatically when
    +    enabling/disabling custom roles, these groups are supposed to be always
    +    enabled.
     
    -diff --git a/etc/upgrade/4.4.4/content b/etc/upgrade/4.4.4/content
    -new file mode 100644
    ---- /dev/null
    -+++ b/etc/upgrade/4.4.4/content
    +diff --git a/etc/upgrade/4.4.5/content b/etc/upgrade/4.4.5/content
    +--- a/etc/upgrade/4.4.5/content
    ++++ b/etc/upgrade/4.4.5/content
     @@
    -+use strict;
    -+use warnings;
    +         ExecModule           => 'ViaInterface',
    +     },
    + );
     +
     +our @Final = (
     +    sub {
    @@ -25,6 +26,5 @@
     +            my ( $ret, $msg ) = $role_group->SetDisabled( 0 );
     +            RT->Logger->error( "Couldn't enable role group #" . $role_group->id . ": $msg" ) unless $ret;
     +        }
    -+
     +    },
     +);



More information about the rt-commit mailing list