[Rt-commit] rt branch, 5.0/queue-list-all-statuses, updated. rt-5.0.1-331-ga71a1c96bc

[? sunnavy]

The branch, 5.0/queue-list-all-statuses has been updated
       via  a71a1c96bc2f6e939022488e9be96839f5138b8a (commit)
      from  7f53ffa0428f3e9cf130817031ae7fe778d9e691 (commit)

Summary of changes:
 share/html/Elements/QueueSummaryByLifecycle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit a71a1c96bc2f6e939022488e9be96839f5138b8a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed May 5 03:36:17 2021 +0800

    Explicitly exclude "deleted" status from queue list
    
    Status "deleted" is quite speical that we skip deleted tickets on most
    pages on purpose, e.g. deleted tickets are not shown in search results.
    
    If we added "deleted" status here, the values would always be "-", which
    is also misleading.

diff --git a/share/html/Elements/QueueSummaryByLifecycle b/share/html/Elements/QueueSummaryByLifecycle
index d31309c281..129e2c1f52 100644
--- a/share/html/Elements/QueueSummaryByLifecycle
+++ b/share/html/Elements/QueueSummaryByLifecycle
@@ -122,7 +122,7 @@ for my $queue (@$queues) {
 }
 
 my @statuses;
-my %seen;
+my %seen = ( deleted => 1 ); # Always exclude "deleted"
 foreach my $set ( @Statuses ) {
     foreach my $lifecycle ( map $lifecycle{$_}, sort keys %lifecycle ) {
         push @statuses, grep !$seen{ lc $_ }++, $lifecycle->Valid($set);

-----------------------------------------------------------------------