[Rt-commit] rt branch, 4.4/asset-custom-roles, repushed

? sunnavy sunnavy at bestpractical.com
Fri May 21 10:33:20 EDT 2021


The branch 4.4/asset-custom-roles was deleted and repushed:
       was d95fe2d665bb12ba6af73c1607b409aee856d3fa
       now 6261c2a75d3714fdab3c99a7367d22ce5a778a94

 1: 614bf65559 =  1: 614bf65559 Add CustomRoleObj method for loading by GroupType
 2: 28e3352c0a =  2: 28e3352c0a Add RT::Asset->RoleAddresses
 3: 9e0411e950 =  3: 9e0411e950 Factor out a LookupType role from CustomFields
 4: 68af85feb7 =  4: 68af85feb7 Allow RegisterLookupType to provide options besides just FriendlyName
 5: 49740f1d40 =  5: 49740f1d40 Add support for LookupType to custom roles
 6: d32c3c0340 !  6: c6e0aad2af Add custom roles to assets
    @@ -187,19 +187,19 @@
      %# END BPS TAGGED BLOCK }}}
      <table border="0" cellpadding="0" cellspacing="0">
     -% for my $role ( $AssetObj->Roles ) {
    -+% for my $role ( ($AssetObj->Id ? $AssetObj->Id : $CatalogObj)->Roles ) {
    ++% for my $role ( $object->Roles ) {
      <tr class="asset-people-<% CSSClass($role) %>">
      <td class="label">
     -<% loc($role) %>:
    -+<% ($AssetObj->Id ? $AssetObj->Id : $CatalogObj)->LabelForRole($role) %>:
    ++<% $object->LabelForRole($role) %>:
      </td>
      <td class="value" colspan="5">
     -<& /Elements/EmailInput, Name => $role, Size => undef, Default => $ARGS{$role}, Autocomplete => 1, ($AssetObj->Role($role)->{Single} ? () : (AutocompleteType => 'Principals', AutocompleteMultiple => 1)) &>
    -+<& /Elements/EmailInput, Name => $role, Size => undef, Default => $ARGS{$role}, Autocomplete => 1, (($AssetObj->Id ? $AssetObj->Id : $CatalogObj)->Role($role)->{Single} ? () : (AutocompleteType => 'Principals', AutocompleteMultiple => 1)) &>
    ++<& /Elements/EmailInput, Name => $role, Size => undef, Default => $ARGS{$role}, Autocomplete => 1, $object->Role($role)->{Single} ? () : (AutocompleteType => 'Principals', AutocompleteMultiple => 1) &>
      </td>
      </tr>
     +
    -+% my $custom_role = $AssetObj->CustomRoleObj($role);
    ++% my $custom_role = $object->CustomRoleObj($role);
     +% if ($custom_role && $custom_role->EntryHint) {
     +<tr>
     +  <td class="label"> </td>
    @@ -214,6 +214,10 @@
      
      </table>
      
    ++<%init>
    ++my $object = $AssetObj->Id ? $AssetObj : $CatalogObj;
    ++</%init>
    ++
      <%args>
      $AssetObj
     +$CatalogObj
 7: f955f75884 =  7: 1ea0f4649d Add API and web tests for interacting with custom roles on assets
 8: 5a4779e924 =  8: eccd6c7ef2 Relax requirements about role names
 9: 1a28f7faee =  9: d3c99fcc53 Add lookup type to custom role admin page listing
10: fb08f55e8c = 10: 0def8bd2ce Exclude asset custom roles from ticket search
11: dff04c7492 = 11: 6599defb2a Remove custom role name uniqueness restriction
12: 4ae2bd7ac2 = 12: 23038f825e Clear old data when registering the whole custom roles
13: d95fe2d665 = 13: 6261c2a75d Show single custom role's name in the result message of adding members



More information about the rt-commit mailing list