[Rt-commit] rtir branch 5.0/select-incident-text-input-tooltip created. 5.0.1-32-ga7f55c22
BPS Git Server
git at git.bestpractical.com
Mon Nov 8 20:03:43 UTC 2021
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rtir".
The branch, 5.0/select-incident-text-input-tooltip has been created
at a7f55c22b142c400e1430b9e18c747016e8e53e9 (commit)
- Log -----------------------------------------------------------------
commit a7f55c22b142c400e1430b9e18c747016e8e53e9
Author: sunnavy <sunnavy at bestpractical.com>
Date: Tue Nov 9 03:38:14 2021 +0800
Add tooltip to select incident text input if it's below the label
The "Incident" label has the tooltip, but when the text input is not in the
same row, people might be confused, especially if the selectable incident
list is long. This commit adds another similar tooltip when the label and
text input are not aligned.
Note that the tooltip doesn't contain the "Required" or "Optional" info,
because it depends on if there is an incident selected or not. It's too
much to dynamicaly update the tooltip depending on other inputs, especially
that the tooltip is hidden by default, so people might not even notice
the change. Keeping this part in the main "Incident" label seems enough.
diff --git a/html/RTIR/Elements/SelectIncident b/html/RTIR/Elements/SelectIncident
index 1ff9e59b..a82ca68e 100644
--- a/html/RTIR/Elements/SelectIncident
+++ b/html/RTIR/Elements/SelectIncident
@@ -67,6 +67,12 @@
% if ( $hide ) {
<input type="hidden" name="<% $Name %>" value="<% $potential[0] %>" />
% }
+
+% if ( @potential ) {
+ <div class="col-auto label">
+ <span class="far fa-question-circle icon-helper" data-toggle="tooltip" data-placement="top" data-original-title="<&|/l&>Id of an Incident to link a new ticket to</&>."</span>
+ </div>
+% }
<div class="col-auto">
<input class="form-control" type="text" name="<% $Name %>" value="" data-autocomplete="Tickets" data-autocomplete-limit="Lifecycle = 'incidents'" />
</div>
-----------------------------------------------------------------------
hooks/post-receive
--
rtir
More information about the rt-commit
mailing list