[Rt-commit] rt branch 5.0/consistent-modal-header-close-button created. rt-5.0.2-25-g9ed15f25b0

BPS Git Server git at git.bestpractical.com
Tue Oct 26 17:23:45 UTC 2021

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/consistent-modal-header-close-button has been created
        at  9ed15f25b03a7e0c6c0424831bda4923778aac57 (commit)

- Log -----------------------------------------------------------------
commit 9ed15f25b03a7e0c6c0424831bda4923778aac57
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Oct 27 00:39:01 2021 +0800

    Switch to link button for "Close" in modal of "Grant Dashboard Rights"
    This is for consistency. Plain button has a background color set on
    hover, which looks weird here, especially considering that other Close
    buttons don't have it.

diff --git a/share/html/Admin/Elements/EditRights b/share/html/Admin/Elements/EditRights
index b028057eb6..87c770728a 100644
--- a/share/html/Admin/Elements/EditRights
+++ b/share/html/Admin/Elements/EditRights
@@ -326,9 +326,9 @@ if ( $AddPrincipal ) {
     <div class="modal-content">
       <div class="modal-header">
         <h5 class="modal-title"><&|/l&>Grant Dashboard Rights</&></h5>
-        <button type="button" class="close" data-dismiss="modal" aria-label="Close">
+        <a href="javascript:void(0)" class="close" data-dismiss="modal" aria-label="Close">
           <span aria-hidden="true">×</span>
-        </button>
+        </a>
       <div class="modal-body">



More information about the rt-commit mailing list