[Rt-commit] rt branch 5.0.2-releng updated. rt-5.0.2beta1-25-g92ff0e37a0

BPS Git Server git at git.bestpractical.com
Mon Sep 13 20:48:49 UTC 2021


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0.2-releng has been updated
       via  92ff0e37a080ad3746a5fb8d0c63fddc7328c8bc (commit)
       via  60cf513ba68b8a2c875613dbd31567553840980c (commit)
      from  261117357c8f1fa0c83af06a6d71c6a64fcc7d09 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 92ff0e37a080ad3746a5fb8d0c63fddc7328c8bc
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Sep 14 04:19:56 2021 +0800

    Capture the permission warning for inline test mode
    
    As we restart server below, the test doesn't fail in other test modes,
    but does fail in inline mode.

diff --git a/t/web/admin_tools_editconfig.t b/t/web/admin_tools_editconfig.t
index 0b3addbd71..366bf7f596 100644
--- a/t/web/admin_tools_editconfig.t
+++ b/t/web/admin_tools_editconfig.t
@@ -13,6 +13,7 @@ $m->follow_link_ok( { text => 'System Configuration' }, 'followed link to "Syste
 ok( !$m->find_link( text => 'Edit' ), 'no edit link' );
 $m->get_ok('/Admin/Tools/EditConfig.html');
 $m->content_contains('Permission Denied');
+$m->warning_like( qr/Permission Denied/, 'Permission denied warning' );
 
 RT::Test->stop_server;
 RT->Config->Set( ShowEditSystemConfig => 1 );

commit 60cf513ba68b8a2c875613dbd31567553840980c
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Sep 14 04:18:50 2021 +0800

    Migrate to RT::Test::Crypt for code that still uses deprecated RT::Test::SMIME

diff --git a/t/mail/smime/separate_certs.t b/t/mail/smime/separate_certs.t
index 9e11df60bf..7a0870c1fb 100644
--- a/t/mail/smime/separate_certs.t
+++ b/t/mail/smime/separate_certs.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use RT::Test::SMIME tests => undef;
+use RT::Test::Crypt SMIME => 1, tests => undef;
 
 use IPC::Run3 'run3';
 use Test::Warn;
@@ -25,7 +25,7 @@ my $key_ring = RT->Config->Get('SMIME')->{'Keyring'};
 for my $key ( keys %signing ) {
     diag "Testing signing with $key";
 
-    RT::Test::SMIME->import_key('sender at example.com');
+    RT::Test::Crypt->smime_import_key('sender at example.com');
     if ( $key ne 'sender at example.com' ) {
         rename File::Spec->catfile( $key_ring, 'sender at example.com.pem' ), File::Spec->catfile( $key_ring, $key )
           or die $!;
@@ -47,7 +47,7 @@ END
         like( $mails[0], qr'Content-Type: application/x-pkcs7-signature', 'Sent message contains signature' );
 
         my ( $buf, $err );
-        run3( [ qw(openssl smime -verify), '-CAfile', RT::Test::SMIME->key_path . "/demoCA/cacert.pem", ],
+        run3( [ qw(openssl smime -verify), '-CAfile', RT::Test::Crypt->smime_key_path . "/demoCA/cacert.pem", ],
             \$mails[0], \$buf, \$err );
 
         like( $err, qr'Verification successful', 'Verification output' );
@@ -73,12 +73,12 @@ my %encryption = (
 my $root = RT::Test->load_or_create_user( Name => 'root' );
 ( $ret, $msg ) = $root->SetEmailAddress('root at example.com');
 ok( $ret, 'set root email to root at example.com' );
-RT::Test::SMIME->import_key( 'root at example.com', $root );
+RT::Test::Crypt->smime_import_key( 'root at example.com', $root );
 
 for my $key ( keys %encryption ) {
     diag "Testing decryption with $key";
 
-    RT::Test::SMIME->import_key('sender at example.com');
+    RT::Test::Crypt->smime_import_key('sender at example.com');
     if ( $key ne 'sender at example.com' ) {
         rename File::Spec->catfile( $key_ring, 'sender at example.com.pem' ), File::Spec->catfile( $key_ring, $key )
           or die $!;
@@ -90,7 +90,7 @@ for my $key ( keys %encryption ) {
             -from    => 'root at example.com',
             -to      => 'sender at example.com',
             -subject => "Encrypted message for queue",
-            RT::Test::SMIME->key_path('sender at example.com.crt'),
+            RT::Test::Crypt->smime_key_path('sender at example.com.crt'),
         ],
         \"\nthis is content",
         \$buf,

-----------------------------------------------------------------------

Summary of changes:
 t/mail/smime/separate_certs.t  | 12 ++++++------
 t/web/admin_tools_editconfig.t |  1 +
 2 files changed, 7 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list