[Rt-commit] rt branch 5.0/document-owneremail-use created. rt-5.0.2-53-ga3b80b8ba0

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/document-owneremail-use has been created
        at  a3b80b8ba0ce56982e7f145887c4fa87ddd9ccac (commit)

- Log -----------------------------------------------------------------
commit a3b80b8ba0ce56982e7f145887c4fa87ddd9ccac
Author: Brian Conry <bconry at bestpractical.com>
Date:   Wed Dec 22 12:58:27 2021 -0600

    Document how OwnerEmail is used
    
    Add detail on how OwnerEmail is used so that someone configuring RT will
    have a better idea of how to set that option.

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index b0b0c5cc65..962d806104 100644
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -388,9 +388,43 @@ setting enabled.
 =item C<$OwnerEmail>
 
 C<$OwnerEmail> is the address of a human who manages RT. RT will send
-errors generated by the mail gateway to this address. Because RT
-sends errors to this address, it should I<not> be an address that's
-managed by your RT instance, to avoid mail loops.
+several classes of errors to this address. To avoid mail loops,
+this option should I<not> be set to an address that's managed by your
+RT instance.
+
+The default is to send email to C<root> on the server where RT is
+running. If your system is not set up to forward root email to a
+real email address, you should set this to RT's admin. If you don't
+want to send any email, you can set this to C<undef>. This will
+prevent the local root account from gathering email that no one is
+looking at.
+
+Examples of errors sent to this address are:
+
+=over 4
+
+=item Insufficient Permissions
+
+When someone tries to create or update a ticket using email and
+lacks the necessary rights.
+
+=item Email Decryption and Encryption Errors
+
+When there is a failure in decoding or decrypting incoming
+email, or encrypting outgoing email. These will alert you
+to a configuration issue with one or more addresses.
+
+=item Mail Loops
+
+If C<$LoopsToRTOwner> is set, then whenever RT detects a mail loop.
+
+=item Dashboard Mailer Responses
+
+If L</$DashboardAddress> isn't set then C<$OwnerEMail> will be used
+as the From address for dashboard emails. Responses to these
+emails will then go to C<$OwnerEmail>.
+
+=back
 
 =cut
 

commit a63e69e1622339c401f64170798995d24618b40f
Author: Brian Conry <bconry at bestpractical.com>
Date:   Wed Dec 22 11:08:44 2021 -0600

    Update PSGI error page for RTSupportEmail
    
    As part of the separation of duties from OwnerEmail.

diff --git a/lib/RT/Interface/Web/Handler.pm b/lib/RT/Interface/Web/Handler.pm
index dd6fc31801..fa03a8e5a2 100644
--- a/lib/RT/Interface/Web/Handler.pm
+++ b/lib/RT/Interface/Web/Handler.pm
@@ -286,7 +286,7 @@ sub PSGIApp {
             unless (eval { RT::ConnectToDatabase() }) {
                 my $res = Plack::Response->new(503);
                 $res->content_type("text/plain");
-                $res->body("Database inaccessible; contact the RT administrator (".RT->Config->Get("OwnerEmail").")");
+                $res->body("Database inaccessible; contact the RT administrator (".RT->Config->Get("RTSupportEmail").")");
                 return $self->_psgi_response_cb( $res->finalize, sub { $self->CleanupRequest } );
             }
         }

commit fdcbaf6737c988ce980ac9723c8edc630c9c4c57
Author: Brian Conry <bconry at bestpractical.com>
Date:   Wed Dec 22 10:01:21 2021 -0600

    Update RemoteAuth error page to use RTSupportEmail
    
    To be consistent with the separation of duties from OwnerEmail.

diff --git a/share/html/Errors/WebRemoteUser/Wrapper b/share/html/Errors/WebRemoteUser/Wrapper
index 058773bdd6..43873cfa19 100644
--- a/share/html/Errors/WebRemoteUser/Wrapper
+++ b/share/html/Errors/WebRemoteUser/Wrapper
@@ -62,9 +62,9 @@ my $login_url = $m->interp->apply_escapes(RT::Interface::Web::TangentForLoginURL
     <% $m->content |n%>
 
     <p id="contact-admin">
-% if (my $owner = RT->Config->Get('OwnerEmail')) {
-%     $owner = $m->interp->apply_escapes($owner, 'h');
-      <&|/l_unsafe, qq[<a href="mailto:$owner">], $owner, '</a>' &>Contact your RT administrator via [_1]email to [_2][_3].</&>
+% if (my $contact = RT->Config->Get('RTSupportEmail')) {
+%     $contact = $m->interp->apply_escapes($contact, 'h');
+      <&|/l_unsafe, qq[<a href="mailto:$contact">], $contact, '</a>' &>Contact your RT administrator via [_1]email to [_2][_3].</&>
 % } else {
       <&|/l&>Contact your RT administrator.</&>
 % }

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt