[Rt-commit] rt branch 4.4/github-actions-updates created. rt-4.4.6-30-g4561ec7ede

BPS Git Server git at git.bestpractical.com
Fri Aug 5 19:10:10 UTC 2022


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 4.4/github-actions-updates has been created
        at  4561ec7ede2211a3d5f39b0be389f62ff0f2216c (commit)

- Log -----------------------------------------------------------------
commit 4561ec7ede2211a3d5f39b0be389f62ff0f2216c
Author: Jesse Vincent <jesse at keyboard.io>
Date:   Wed Aug 3 15:20:55 2022 -0400

    "if: always()" is a noop. Remove it to reduce visual clutter

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index 24677373b0..2da2cc428a 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -31,7 +31,6 @@ jobs:
         shell: bash
         run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
-        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)
@@ -84,7 +83,6 @@ jobs:
         shell: bash
         run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
-        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)
@@ -138,7 +136,6 @@ jobs:
         shell: bash
         run: docker exec -e RT_DBA_USER=postgres -e RT_TEST_WEB_HANDLER=apache+fcgid -e HTTPD_ROOT=/etc/apache2 -e RT_TEST_APACHE=/usr/sbin/apache2 -e RT_TEST_APACHE_MODULES=/usr/lib/apache2/modules -u rt-user rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
-        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)

commit b1ff93f685d698f69fbd21c36d70c39a4975e02f
Author: Jesse Vincent <jesse at keyboard.io>
Date:   Wed Aug 3 15:17:27 2022 -0400

    Switch the github test harness to using RT's built in parallel testing make target.
    
    This make the github workflows a little less complicated and turns on
    some prove options that help make the test suites finish a bit faster.
    
    * Cache the .prove state file so that "make test-parallel" will run the
      slowest test suites first, which generally results in faster test
      suite runs
    * Switch to a parallelism of 5, which currently benchmarks a hair faster
      than a parallelism of 6 for me on GitHub's current runners

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index e2f624c0a6..24677373b0 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -15,6 +15,12 @@ jobs:
           echo "RT_GA_START_TIME=$(date +%s)" >> $GITHUB_ENV
       - name: Check out RT
         uses: actions/checkout at v2
+      - name: Cache .prove state
+        id: cache-prove-state
+        uses: actions/cache at v3
+        with:
+          path: .prove
+          key: ${{ runner.os }}-sqlite
       - name: Build RT
         shell: bash
         run: |
@@ -23,7 +29,7 @@ jobs:
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=SQLite --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
         shell: bash
-        run: docker exec rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
         if: always()
         shell: bash
@@ -60,6 +66,12 @@ jobs:
           echo "RT_GA_START_TIME=$(date +%s)" >> $GITHUB_ENV
       - name: Checkout RT
         uses: actions/checkout at v2
+      - name: Cache .prove state
+        id: cache-prove-state
+        uses: actions/cache at v3
+        with:
+          path: .prove
+          key: ${{ runner.os }}-mariadb
       - name: Build RT
         shell: bash
         run: |
@@ -70,7 +82,7 @@ jobs:
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=mysql --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
         shell: bash
-        run: docker exec rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
         if: always()
         shell: bash
@@ -107,6 +119,12 @@ jobs:
           echo "RT_GA_START_TIME=$(date +%s)" >> $GITHUB_ENV
       - name: Checkout RT
         uses: actions/checkout at v2
+      - name: Cache .prove state
+        id: cache-prove-state
+        uses: actions/cache at v3
+        with:
+          path: .prove
+          key: ${{ runner.os }}-pg-fcgid
       - name: Build RT
         shell: bash
         run: |
@@ -118,7 +136,7 @@ jobs:
           docker exec -e USER=rt-user -u rt-user rt bash -c "cd /rt && ./configure.ac --with-db-type=Pg --with-my-user-group --enable-layout=inplace --with-web-handler=fcgid --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps && chmod a+rX /rt/sbin/*"
       - name: Run RT tests
         shell: bash
-        run: docker exec -e RT_DBA_USER=postgres -e RT_TEST_WEB_HANDLER=apache+fcgid -e HTTPD_ROOT=/etc/apache2 -e RT_TEST_APACHE=/usr/sbin/apache2 -e RT_TEST_APACHE_MODULES=/usr/lib/apache2/modules -u rt-user rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec -e RT_DBA_USER=postgres -e RT_TEST_WEB_HANDLER=apache+fcgid -e HTTPD_ROOT=/etc/apache2 -e RT_TEST_APACHE=/usr/sbin/apache2 -e RT_TEST_APACHE_MODULES=/usr/lib/apache2/modules -u rt-user rt bash -c "cd /rt && RT_TEST_PARALLEL_NUM=5 make test-parallel"
       - name: Get run time
         if: always()
         shell: bash

commit 8f5e491596b9027fddbbe1ad31f7c2901d9ec59c
Author: Jesse Vincent <jesse at keyboard.io>
Date:   Wed Aug 3 15:16:24 2022 -0400

    Only run the "Slack notification" test step inside the bestpractical org
    
    This makes the github testsuite workflows not always fail when run on
    forks

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index af95b96f39..e2f624c0a6 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -37,7 +37,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: always()
+        if: ${{ github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}
@@ -84,7 +84,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: always()
+        if: ${{ github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}
@@ -132,7 +132,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: always()
+        if: ${{ github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list