[Rt-commit] rt branch 4.4/always-post-github-to-slack created. rt-4.4.6-33-g596720497c

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 4.4/always-post-github-to-slack has been created
        at  596720497cbb805b7864d8267cef91b5eedda492 (commit)

- Log -----------------------------------------------------------------
commit 596720497cbb805b7864d8267cef91b5eedda492
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Mon Aug 22 08:46:49 2022 -0400

    Restore the github actions always() for slack notifications
    
    The always() is needed for slack notifications also or
    test failures are not reported. The previous setting was
    removed as part of adding the conditional to report to
    slack only when running in the bestpractical account
    in 8f5e4915.

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index e13bd3fcaf..f3d514c8bd 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -44,7 +44,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: ${{ github.repository_owner == 'bestpractical' }}
+        if: ${{ always() && github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}
@@ -97,7 +97,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: ${{ github.repository_owner == 'bestpractical' }}
+        if: ${{ always() && github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}
@@ -151,7 +151,7 @@ jobs:
           export RT_GA_TEST_TIME=$(date -u -d @"$RT_GA_TEST_TIME" +"%T")
           echo "RT_GA_TEST_TIME=$RT_GA_TEST_TIME" >> $GITHUB_ENV
       - name: Post results to Slack
-        if: ${{ github.repository_owner == 'bestpractical' }}
+        if: ${{ always() && github.repository_owner == 'bestpractical' }}
         uses: edge/simple-slack-notify at v1.1.1
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_NOTIFICATIONS }}

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt