[Rt-commit] rt branch 5.0/fix-broken-pod-in-rt-validator created. rt-5.0.3-199-ge2d12486bd

BPS Git Server git at git.bestpractical.com
Fri Dec 9 21:47:30 UTC 2022


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/fix-broken-pod-in-rt-validator has been created
        at  e2d12486bdb86222b8fafe61dfeb3d1fb58e31ce (commit)

- Log -----------------------------------------------------------------
commit e2d12486bdb86222b8fafe61dfeb3d1fb58e31ce
Author: Jason Crome <jcrome at bestpractical.com>
Date:   Fri Dec 9 08:52:26 2022 -0500

    Remove trailing whitespace

diff --git a/sbin/rt-validator.in b/sbin/rt-validator.in
index 0722ce2c91..aed0da269c 100644
--- a/sbin/rt-validator.in
+++ b/sbin/rt-validator.in
@@ -559,7 +559,7 @@ push @CHECKS, 'CGM vs. GM' => sub {
     );
 
     # for every CGM where ImmediateParentId != GroupId there should be
-    # matching parent record (first level) 
+    # matching parent record (first level)
     $res *= check_integrity(
         CachedGroupMembers => ['ImmediateParentId', 'MemberId'],
         CachedGroupMembers => ['GroupId', 'MemberId'],
@@ -1619,7 +1619,7 @@ rt-validator - check and correct validity of records in RT's database
 
 =head1 SYNOPSIS
 
-    rt-validator --check 
+    rt-validator --check
     rt-validator --check --verbose
     rt-validator --check --verbose --resolve
     rt-validator --check --verbose --resolve --force
@@ -1636,7 +1636,7 @@ records or ressurect accidentally deleted.
 =item check
 
     mandatory.
-    
+
     it's equal to -c
 
 =item verbose
@@ -1652,7 +1652,7 @@ records or ressurect accidentally deleted.
 
     resolve without asking questions
 
-=item links-only 
+=item links-only
 
     only run the Link validation routines, useful if you changed your Organization
 

commit 5401efec0d05dffda75c7088c2379e908a21928f
Author: Jason Crome <jcrome at bestpractical.com>
Date:   Fri Dec 9 08:48:59 2022 -0500

    Fix broken Pod in rt-validator
    
    The Pod for check_integrity appears between the table of contents and
    NAME directive in the Pod when rendered to HTML (with the link to the
    function appearing first in the TOC), and rendering to text is similarly
    broken.
    
    As this is a utility rather than a library, and check_integrity is not
    used outside of this utility, these docs are best represented as
    comments instead.

diff --git a/sbin/rt-validator.in b/sbin/rt-validator.in
index ba67577e23..0722ce2c91 100644
--- a/sbin/rt-validator.in
+++ b/sbin/rt-validator.in
@@ -1339,17 +1339,14 @@ while ( my $check = shift @do_check ) {
 exit 1 unless $status;
 exit 0;
 
-=head2 check_integrity
-
-Takes two (table name, column(s)) pairs. First pair
-is reference we check and second is destination that
-must exist. Array reference can be used for multiple
-columns.
-
-Returns 0 if a record is missing or 1 otherwise.
-
-=cut
-
+#
+# Takes two (table name, column(s)) pairs. First pair
+# is reference we check and second is destination that
+# must exist. Array reference can be used for multiple
+# columns.
+#
+# Returns 0 if a record is missing or 1 otherwise.
+#
 sub check_integrity {
     my ($stable, @scols) = (shift, shift);
     my ($ttable, @tcols) = (shift, shift);
@@ -1660,4 +1657,3 @@ records or ressurect accidentally deleted.
     only run the Link validation routines, useful if you changed your Organization
 
 =back
-

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list