[Rt-commit] rt branch 4.4/docker-testing-buster updated. rt-4.4.6-21-g5ed78e7766

BPS Git Server git at git.bestpractical.com
Fri Jul 22 20:21:27 UTC 2022


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 4.4/docker-testing-buster has been updated
       via  5ed78e776640e97014bb2536f21900dc46dd2d7d (commit)
       via  f1ca6825c5745f46cbc511f912b5c043c0bab7c9 (commit)
       via  d77eabafc92042777ef6592b2ca055960357606b (commit)
       via  d221f86274d8076006919abe186b8ee781c2b743 (commit)
      from  50fdca6beb25d0b81a4820f470a8a01d18e63620 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5ed78e776640e97014bb2536f21900dc46dd2d7d
Author: Brett Smith <brett at bestpractical.com>
Date:   Tue Aug 10 09:15:17 2021 -0400

    Clean up Travis cruft from GitHub Actions
    
    These lines are simply carried over and commented out from our Travis
    pipeline. They don't mean anything special to GitHub Actions. I thought
    they might, so clean those up to prevent future readers from going down
    the same rabbit hole.

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index 20c127b93f..c51ece8719 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -1,6 +1,3 @@
-#language: bash
-#services: docker
-
 on:
   push:
     branches-ignore:

commit f1ca6825c5745f46cbc511f912b5c043c0bab7c9
Author: Brett Smith <brett at bestpractical.com>
Date:   Tue Aug 10 08:49:05 2021 -0400

    Remove `docker ps` calls from GitHub Actions
    
    This is strictly an informational command. It's basically acting as a
    debug print here. I don't think it's worth keeping anymore.

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index c4a705a8ec..20c127b93f 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -23,7 +23,6 @@ jobs:
         run: |
           docker build -t rt-base .
           docker run -d -v $GITHUB_WORKSPACE:/rt --name rt rt-base
-          docker ps -a
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=SQLite --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
         shell: bash
@@ -70,7 +69,6 @@ jobs:
           docker run --name mariadb -e MYSQL_ROOT_PASSWORD=password -d mariadb:10.6
           docker build -t rt-base .
           docker run -d -v $GITHUB_WORKSPACE:/rt --name rt --link mariadb:db rt-base
-          docker ps -a
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=mysql --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
         shell: bash
@@ -117,7 +115,6 @@ jobs:
           docker run --name postgresql --mount type=tmpfs,destination=/var/lib/postgresql/data -e POSTGRES_PASSWORD=password -d postgres:12.8
           docker build -t rt-base .
           docker run -d -v $GITHUB_WORKSPACE:/rt --name rt --link postgresql:db rt-base
-          docker ps -a
           docker exec rt bash -c "chown -R rt-user /rt; touch /etc/apache2/mime.types"
           docker exec -e USER=rt-user -u rt-user rt bash -c "cd /rt && ./configure.ac --with-db-type=Pg --with-my-user-group --enable-layout=inplace --with-web-handler=fcgid --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps && chmod a+rX /rt/sbin/*"
       - name: Run RT tests

commit d77eabafc92042777ef6592b2ca055960357606b
Author: Brett Smith <brett at bestpractical.com>
Date:   Tue Aug 10 08:43:42 2021 -0400

    Remove unused envvars from GitHub Actions
    
    Docker containers and images only get environment variables explicitly
    defined in the Dockerfile or `docker` command. Most of the `env` blocks
    in our step definitions are therefore noops and can be safely removed.
    
    Similarly, `--env` arguments that are already defined in the Dockerfile
    are redundant and also noops. Clean those up too.

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index b1e68936ba..c4a705a8ec 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -19,8 +19,6 @@ jobs:
       - name: Check out RT
         uses: actions/checkout at v2
       - name: Build RT
-        env:
-          RT_TEST_PARALLEL: 1
         shell: bash
         run: |
           docker build -t rt-base .
@@ -29,7 +27,7 @@ jobs:
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=SQLite --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
         shell: bash
-        run: docker exec -e RT_TEST_PARALLEL=1 rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec -e rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
         if: always()
         shell: bash
@@ -67,26 +65,16 @@ jobs:
       - name: Checkout RT
         uses: actions/checkout at v2
       - name: Build RT
-        env:
-          RT_TEST_PARALLEL: 1
-          RT_DBA_USER: root
-          RT_DBA_PASSWORD: password
-          DB_VERSION_TAG: 10.6
         shell: bash
         run: |
-          docker run --name mariadb -e MYSQL_ROOT_PASSWORD=password -d mariadb:$DB_VERSION_TAG
+          docker run --name mariadb -e MYSQL_ROOT_PASSWORD=password -d mariadb:10.6
           docker build -t rt-base .
           docker run -d -v $GITHUB_WORKSPACE:/rt --name rt --link mariadb:db rt-base
           docker ps -a
           docker exec rt bash -c "cd /rt && ./configure.ac --with-db-type=mysql --with-my-user-group --enable-layout=inplace --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps"
       - name: Run RT tests
-        env:
-          RT_TEST_PARALLEL: 1
-          RT_DBA_USER: root
-          RT_DBA_PASSWORD: password
-          DB_VERSION_TAG: 10.6
         shell: bash
-        run: docker exec -e RT_TEST_PARALLEL=1 -e RT_DBA_USER=root -e RT_DBA_PASSWORD=password rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
         if: always()
         shell: bash
@@ -124,31 +112,17 @@ jobs:
       - name: Checkout RT
         uses: actions/checkout at v2
       - name: Build RT
-        env:
-          DB_VERSION_TAG: 12.8
-          RT_TEST_PARALLEL: 1
-          RT_TEST_WEB_HANDLER: apache+fcgid
-          HTTPD_ROOT: /etc/apache2
-          RT_TEST_APACHE: /usr/sbin/apache2
-          RT_TEST_APACHE_MODULES: /usr/lib/apache2/modules
         shell: bash
         run: |
-          docker run --name postgresql --mount type=tmpfs,destination=/var/lib/postgresql/data -e POSTGRES_PASSWORD=password -d postgres:$DB_VERSION_TAG
+          docker run --name postgresql --mount type=tmpfs,destination=/var/lib/postgresql/data -e POSTGRES_PASSWORD=password -d postgres:12.8
           docker build -t rt-base .
           docker run -d -v $GITHUB_WORKSPACE:/rt --name rt --link postgresql:db rt-base
           docker ps -a
           docker exec rt bash -c "chown -R rt-user /rt; touch /etc/apache2/mime.types"
           docker exec -e USER=rt-user -u rt-user rt bash -c "cd /rt && ./configure.ac --with-db-type=Pg --with-my-user-group --enable-layout=inplace --with-web-handler=fcgid --enable-developer --enable-externalauth --enable-gpg --enable-smime && mkdir -p /rt/var && make testdeps && chmod a+rX /rt/sbin/*"
       - name: Run RT tests
-        env:
-          DB_VERSION_TAG: 12.8
-          RT_TEST_PARALLEL: 1
-          RT_TEST_WEB_HANDLER: apache+fcgid
-          HTTPD_ROOT: /etc/apache2
-          RT_TEST_APACHE: /usr/sbin/apache2
-          RT_TEST_APACHE_MODULES: /usr/lib/apache2/modules
         shell: bash
-        run: docker exec -e RT_TEST_PARALLEL=1 -e RT_DBA_USER=postgres -e RT_DBA_PASSWORD=password -u rt-user rt bash -c "cd /rt && prove -rlj6 t/*"
+        run: docker exec -e RT_DBA_USER=postgres -e RT_TEST_WEB_HANDLER=apache+fcgid -e HTTPD_ROOT=/etc/apache2 -e RT_TEST_APACHE=/usr/sbin/apache2 -e RT_TEST_APACHE_MODULES=/usr/lib/apache2/modules -u rt-user rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
         if: always()
         shell: bash

commit d221f86274d8076006919abe186b8ee781c2b743
Author: Brett Smith <brett at bestpractical.com>
Date:   Tue Aug 10 08:33:24 2021 -0400

    Always get run time of GitHub Actions tests
    
    The Slack notification always uses the variables set in this step, no
    matter the status of the earlier steps of the job, so this step needs to
    always run too. Otherwise the Slack notification for failed tests
    reports the time as "undefined".

diff --git a/.github/workflows/github-action.yml b/.github/workflows/github-action.yml
index 9545b2c777..b1e68936ba 100644
--- a/.github/workflows/github-action.yml
+++ b/.github/workflows/github-action.yml
@@ -31,6 +31,7 @@ jobs:
         shell: bash
         run: docker exec -e RT_TEST_PARALLEL=1 rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
+        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)
@@ -87,6 +88,7 @@ jobs:
         shell: bash
         run: docker exec -e RT_TEST_PARALLEL=1 -e RT_DBA_USER=root -e RT_DBA_PASSWORD=password rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
+        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)
@@ -148,6 +150,7 @@ jobs:
         shell: bash
         run: docker exec -e RT_TEST_PARALLEL=1 -e RT_DBA_USER=postgres -e RT_DBA_PASSWORD=password -u rt-user rt bash -c "cd /rt && prove -rlj6 t/*"
       - name: Get run time
+        if: always()
         shell: bash
         run: |
           export RT_GA_END_TIME=$(date +%s)

-----------------------------------------------------------------------

Summary of changes:
 .github/workflows/github-action.yml | 45 +++++++------------------------------
 1 file changed, 8 insertions(+), 37 deletions(-)


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list