[Rt-commit] rtir branch 5.0-trunk updated. 5.0.1-68-g9f93a2e5
BPS Git Server
git at git.bestpractical.com
Thu Mar 10 15:19:40 UTC 2022
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rtir".
The branch, 5.0-trunk has been updated
via 9f93a2e53f7fe61a296de2dd6b7e8c3c45f6a6ef (commit)
via e8e58de6a8938a870f38850955ba03030d749557 (commit)
via fb716c48b98bd594d22863ade4342c88181c2f02 (commit)
via be9deb1110e518f7f7f21b25c25babde1942d900 (commit)
via 15b152b5319f6cf2a89f67595a84c332832f238a (commit)
from 8bf19b3fef288b9174925a0c9b8a8ed80b15786f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9f93a2e53f7fe61a296de2dd6b7e8c3c45f6a6ef
Merge: 8bf19b3f e8e58de6
Author: Jim Brandt <jbrandt at bestpractical.com>
Date: Wed Mar 9 17:19:21 2022 -0500
Merge branch '5.0/work-with-timetracking' into 5.0-trunk
diff --cc docs/UPGRADING-5.0
index 2497cbc0,50c89326..0bebcf51
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@@ -172,52 -172,25 +172,71 @@@ All users can see the default System da
want to allow users to see other System dashboards, grant the
"SeeDashboard" right. This is not done automatically with the upgrade.
+=item * Global "RTIR at a glance" configuration page
+
+For RT admins, Admin > Global > RTIR at a glance is now available, and
+instead of loading the page configuration editor, it shows a list of
+System dashboards that can be set as the default homepage.
+
+=item * RT's Default Article Content Custom Field is Deselected
+
+When initially installing RT, a global custom field Content is created
+and applied to Articles. RTIR also creates an Article custom field on
+installation, called Response. The default DutyTeam group has rights to
+use the Response CF, but not the Content CF and typically for boilerplate
+email responses you need only one custom field. The extra CF can also cause
+issues with automatically inserting content on the ticket reply page.
+
+As part of this update, we deselect the Content CF from the Templates
+class, which is the default for RTIR. This should make the Response CF
+work as intended. If you are using the Content CF in some way, you
+can edit the Templates class configuration and enable it again.
+
+=item * CVE ID Custom Field Added
+
+A new default custom field called C<CVE ID> is added with this upgrade.
+On Incidents with a CVE defined, some information about the CVE from
+the NIST vulnerability system is displayed on the page with a link
+to the full description on the NIST website.
+
+CVE IDs can also now be parsed and automatically added to this
+custom field from incoming email, similar to IP addresses.
+
+If you don't track CVEs with your RTIR instance, you can disable
+the custom field and the new scrips.
+
+=item * Run Transaction Batch last, even in nested updates
+
+When RTIR processes scrips, Batch mode scrips should always run last.
+Previously, with nested updates, inner updates would run batch before
+all outer updates were complete. One example of this is processing ticket
+updates, the Basics update calls an inner "atomic" transaction to update
+Owner, which would cause the unexpected batch run. This has been fixed
+so batch runs only once for the outermost updates. All transactions
+performed for that batch are available from the C<TransactionBatch> method
+as expected.
+
+This mirrors a change also made in RT 5.0.2.
+
+ =item * Incident Reply Updates
+
+ On the Incident Reply to Reporters and Reply to All pages, "Worked" is now
+ in a new "Incident Time Taken" section to make it clear that you are recording time
+ worked on the incident, and to make it easy to do so. Previously there was a Worked
+ field in the Reply section, which would then apply time to all linked tickets.
+
+ The goal of the Reply to All pages is to send out a notification or update to
+ multiple people in one step, so the time you are reporting is usually on
+ the Incident ticket, not once per linked ticket. However, this is a change from the
+ previous behavior. This update allows for cleaner integration with
+ RT::Extension::TimeTracking, which provides additional time tracking features.
+
+ Processing of the update message was also moved before processing of other ticket
+ updates like Basics (status, etc.), custom fields, and dates. This makes RTIR more
+ consistent with RT, but it's possible this could impact scrips if the relied on
+ Basics or other updates running before message updates. If you have this issue,
+ moving the scrip to Batch mode may restore the previous behavior.
+
=back
=cut
diff --cc html/RTIR/Incident/Display.html
index 175c3286,29fe5499..0249c6b7
--- a/html/RTIR/Incident/Display.html
+++ b/html/RTIR/Incident/Display.html
@@@ -462,7 -451,8 +463,8 @@@ if ( !$SkipProcessing && $ARGS{'Action'
-unless( $new_ticket ) {
+unless( $new_ticket || $SkipProcessing ) {
+ push @results, ProcessUpdateMessage( ARGSRef => \%ARGS, TicketObj => $TicketObj );
push @results, ProcessTicketBasics( ARGSRef => \%ARGS, TicketObj => $TicketObj );
push @results, ProcessObjectCustomFieldUpdates( ARGSRef => \%ARGS, Object => $TicketObj );
push @results, ProcessTicketDates( ARGSRef => \%ARGS, TicketObj => $TicketObj );
diff --cc html/RTIR/Incident/Elements/ReplyForm
index 6f98a136,8425054f..d6f26484
--- a/html/RTIR/Incident/Elements/ReplyForm
+++ b/html/RTIR/Incident/Elements/ReplyForm
@@@ -112,9 -115,8 +115,10 @@@
&>
</div>
</div>
+ % }
+% $m->callback( %ARGS, CallbackName => 'AfterWorked', Ticket => $TicketObj );
+
<& /RTIR/Elements/UpdateData, %ARGS, Ticket => $TicketObj, QueueObj => $QueueObj, Action => $Action &>
</&>
commit e8e58de6a8938a870f38850955ba03030d749557
Author: Jim Brandt <jbrandt at bestpractical.com>
Date: Wed Mar 9 17:16:01 2022 -0500
Document changes to message and time processing
diff --git a/docs/UPGRADING-5.0 b/docs/UPGRADING-5.0
index f912a9f9..50c89326 100644
--- a/docs/UPGRADING-5.0
+++ b/docs/UPGRADING-5.0
@@ -172,6 +172,25 @@ All users can see the default System dashboard set for RTIR. If you
want to allow users to see other System dashboards, grant the
"SeeDashboard" right. This is not done automatically with the upgrade.
+=item * Incident Reply Updates
+
+On the Incident Reply to Reporters and Reply to All pages, "Worked" is now
+in a new "Incident Time Taken" section to make it clear that you are recording time
+worked on the incident, and to make it easy to do so. Previously there was a Worked
+field in the Reply section, which would then apply time to all linked tickets.
+
+The goal of the Reply to All pages is to send out a notification or update to
+multiple people in one step, so the time you are reporting is usually on
+the Incident ticket, not once per linked ticket. However, this is a change from the
+previous behavior. This update allows for cleaner integration with
+RT::Extension::TimeTracking, which provides additional time tracking features.
+
+Processing of the update message was also moved before processing of other ticket
+updates like Basics (status, etc.), custom fields, and dates. This makes RTIR more
+consistent with RT, but it's possible this could impact scrips if the relied on
+Basics or other updates running before message updates. If you have this issue,
+moving the scrip to Batch mode may restore the previous behavior.
+
=back
=cut
-----------------------------------------------------------------------
Summary of changes:
docs/UPGRADING-5.0 | 19 +++++++++++++++++++
html/RTIR/Display.html | 1 +
html/RTIR/Incident/Display.html | 6 ++----
html/RTIR/Incident/Elements/ReplyForm | 4 ++++
html/RTIR/Incident/Reply/index.html | 34 ++++++++++++++++++++++++++++------
5 files changed, 54 insertions(+), 10 deletions(-)
hooks/post-receive
--
rtir
More information about the rt-commit
mailing list