[Rt-commit] rt branch 5.0/theme-try-button created. rt-5.0.2-221-gd5a4efd71f

BPS Git Server git at git.bestpractical.com
Wed May 4 20:54:49 UTC 2022

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/theme-try-button has been created
        at  d5a4efd71f44fb2c0407e6d17247b74b5a8ec5e1 (commit)

- Log -----------------------------------------------------------------
commit d5a4efd71f44fb2c0407e6d17247b74b5a8ec5e1
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Wed May 4 16:39:22 2022 -0400

    Remove submit from theme Try button
    As part of the updates to bootstrap in e3bed571, the Try
    button on the Theme editor was converted to a submit.
    The result is that instead of just reloading the test CSS
    in the current browser via javascript, it saves the update
    to the database and sets it for all users.
    Remove the submit and restore it to just a button.
    This also makes the Reset button useful again as it can
    remove the settings applied with Try.

diff --git a/share/html/Admin/Tools/Theme.html b/share/html/Admin/Tools/Theme.html
index ed921b78af..9c8696f9ce 100644
--- a/share/html/Admin/Tools/Theme.html
+++ b/share/html/Admin/Tools/Theme.html
@@ -88,7 +88,7 @@
     <form method="POST" id="custom-css-form">
       <textarea class="form-control mb-2" rows="20" id="user_css" name="user_css" wrap="off"><% $user_css %></textarea>
-      <input id="try" type="submit" class="button btn btn-primary" value="<&|/l&>Try</&>" />
+      <input id="try" type="button" class="button btn btn-primary" value="<&|/l&>Try</&>" />
       <input id="reset" type="reset" class="button btn btn-primary" value="<&|/l&>Reset</&>" type="submit" />
       <input name="reset_css" class="button btn btn-primary" value="<&|/l&>Reset to default RT Theme</&>" type="submit" />
       <input class="button btn btn-primary" value="<&|/l&>Save</&>" type="submit" />



More information about the rt-commit mailing list