[Rt-commit] rt branch 5.0/retain-class-info-on-invalid-query-edit created. rt-5.0.2-224-g0b524eb194

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/retain-class-info-on-invalid-query-edit has been created
        at  0b524eb19409e7726e5a72c73423f4e8bf7c6a01 (commit)

- Log -----------------------------------------------------------------
commit 0b524eb19409e7726e5a72c73423f4e8bf7c6a01
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu May 19 05:28:26 2022 +0800

    Test invalid queries on transaction search edit page

diff --git a/t/web/search_txns.t b/t/web/search_txns.t
index 7824a6eba7..bf4ca0b817 100644
--- a/t/web/search_txns.t
+++ b/t/web/search_txns.t
@@ -47,6 +47,12 @@ diag "Advanced";
     $m->follow_link_ok( { text => 'Advanced' }, 'Advanced' );
     $m->title_is('Edit Transaction Query');
 
+    $m->form_name('BuildQueryAdvanced');
+    $m->field( Query => q{OldValue = } );
+    $m->submit;
+    $m->text_contains('Incomplete query', 'Got the parse error');
+    $m->title_is('Edit Transaction Query', 'Still on transaction search');
+
     $m->form_name('BuildQueryAdvanced');
     $m->field( Query => q{OldValue = 'new'} );
     $m->submit;

commit 3079bd691761ab51baa70ff5f45ace3ab29a1e48
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu May 19 05:17:45 2022 +0800

    Retain Class and ObjectType when query parsing contains errors
    
    Otherwise it would be ticket search, no matter what you were on before.

diff --git a/share/html/Search/Build.html b/share/html/Search/Build.html
index a9c2a6215f..694420f73d 100644
--- a/share/html/Search/Build.html
+++ b/share/html/Search/Build.html
@@ -254,6 +254,8 @@ if ( @parse_results ) {
         SavedSearchId => $saved_search{'Id'},
         SavedChartSearchId => $ARGS{'SavedChartSearchId'},
         actions => \@actions,
+        Class => $Class,
+        ObjectType => $ObjectType,
     );
 }
 

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt