[Rt-commit] rt branch 5.0/search-filter-icon-style updated. rt-5.0.3-433-g14c81f5160

BPS Git Server git at git.bestpractical.com
Tue Apr 18 21:22:31 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/search-filter-icon-style has been updated
       via  14c81f5160d04c640a2bae50c8fbf09685d9ecf1 (commit)
      from  ef1484b5d99d209496d0bf1d741758e0062acf8d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 14c81f5160d04c640a2bae50c8fbf09685d9ecf1
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Apr 19 03:53:48 2023 +0800

    Do not mark owner search-filter modal scrollable
    
    Class "modal-dialog-scrollable" makes underlying ".modal-body" scroll if
    needed(overflow-y:auto), which is not suitable for Owner as its original
    height is quite small and not enough for expanded bootstrap select
    options.
    
    This commit gets rid of the "modal-dialog-scrollable" class so the
    bootstrap select options can overflow across the whole modal height,
    instead of just the small "modal-body".

diff --git a/share/html/Elements/SearchFilter b/share/html/Elements/SearchFilter
index 58ab611a6b..0496bebd05 100644
--- a/share/html/Elements/SearchFilter
+++ b/share/html/Elements/SearchFilter
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <div class="modal search-results-filter">
-  <div class="modal-dialog modal-dialog-scrollable <% $modal_class %>" role="document">
+  <div class="modal-dialog <% $Attribute eq 'Owner' ? '' : 'modal-dialog-scrollable' %> <% $modal_class %>" role="document">
     <form name="search-results-filter">
       <div class="modal-content">
         <div class="modal-header">

-----------------------------------------------------------------------

Summary of changes:
 share/html/Elements/SearchFilter | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list