[Rt-commit] rt branch 5.0/search-filter-owner-dropdown-size created. rt-5.0.3-513-g45807b3e1a

BPS Git Server git at git.bestpractical.com
Tue Apr 25 16:50:43 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/search-filter-owner-dropdown-size has been created
        at  45807b3e1af61c4f82fc10d23ea4df04a58dd2ce (commit)

- Log -----------------------------------------------------------------
commit 45807b3e1af61c4f82fc10d23ea4df04a58dd2ce
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Apr 25 14:46:51 2023 +0800

    Limit dropdown size in owner search filter modal
    
    The height of owner search filter modal is small, and overflowed
    dropdown items are invisible. Limiting the size to 6 to make use of most
    of the visible space and users can scroll to see all items.

diff --git a/share/html/Elements/SearchFilter b/share/html/Elements/SearchFilter
index 2374848ae7..24172b75d2 100644
--- a/share/html/Elements/SearchFilter
+++ b/share/html/Elements/SearchFilter
@@ -107,7 +107,7 @@
               <&|/l&>Owner</&>:
             </div>
             <div class="value col-9">
-              <& /Elements/SelectOwner, Name => 'Owner', Default => $filter->{Owner} &>
+              <& /Elements/SelectOwner, Name => 'Owner', Default => $filter->{Owner}, Size => 6 &>
             </div>
           </div>
 %       } elsif ( $Attribute eq 'SLA' ) {
diff --git a/share/html/Elements/SelectOwnerDropdown b/share/html/Elements/SelectOwnerDropdown
index 70b2b83d61..44dcee0f84 100644
--- a/share/html/Elements/SelectOwnerDropdown
+++ b/share/html/Elements/SelectOwnerDropdown
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<select name="<%$Name%>" class="selectpicker form-control <%$Name%>">
+<select name="<%$Name%>" class="selectpicker form-control <%$Name%>" <% $Size ? qq{data-size="$Size"} : '' |n %>>
 %if ($DefaultValue) {
 <option value=""<% !$Default ? qq[ selected="selected"] : '' |n %>><%$DefaultLabel |n%></option>
 %}
@@ -122,4 +122,5 @@ $Default => 0
 $DefaultValue => 1
 $DefaultLabel => "-"
 $ValueAttribute => 'id'
+$Size => 0
 </%ARGS>

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list