[Rt-commit] rt branch 5.0/rebalance-page-menu-later created. rt-5.0.4-136-g84fbb14a5c

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/rebalance-page-menu-later has been created
        at  84fbb14a5c25e1695c84aa75470c24be3a3d7b45 (commit)

- Log -----------------------------------------------------------------
commit 84fbb14a5c25e1695c84aa75470c24be3a3d7b45
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Aug 31 10:00:14 2023 -0400

    Rebalance page menu when the entire page(not just dom) is ready
    
    Previously page menu was rebalanced when dom was ready, which is not
    good enough as element widths were not fully nailed yet by then.
    Because of this, sometimes subject and page menu could still overlap.
    
    This commit runs page menu rebalance code when the entire page is
    ready(code for nav menu is already there), at which time we can get more
    accurate element widths and thus rebalance more accurately.

diff --git a/share/html/NoAuth/css/elevator-light/AfterMenus b/share/html/NoAuth/css/elevator-light/AfterMenus
index bec1bf2e55..8d272f5c3c 100644
--- a/share/html/NoAuth/css/elevator-light/AfterMenus
+++ b/share/html/NoAuth/css/elevator-light/AfterMenus
@@ -66,9 +66,6 @@ var initMenus = function() {
     // remove stub elements we added in BeforeNav to get a dropdown indicator
     jQuery('#li-overflow-will_be_deleted').remove();
     jQuery('#li-page-overflow-will_be_deleted').remove();
-
-    rebalanceOverflowMenu('#app-nav', '#li-overflow');
-    rebalanceOverflowMenu('#page-menu', '#li-page-overflow');
 };
 
 // If everything is loaded, init NOW.  Otherwise, defer to DOM ready.
diff --git a/share/html/NoAuth/css/elevator-light/BeforeNav b/share/html/NoAuth/css/elevator-light/BeforeNav
index 180cdeb403..15bb970b02 100644
--- a/share/html/NoAuth/css/elevator-light/BeforeNav
+++ b/share/html/NoAuth/css/elevator-light/BeforeNav
@@ -168,6 +168,7 @@ jQuery(window).on('load', function () {
     jQuery('#topactions').css('right', jQuery('#logo').width() + font_size + 'px');
 
     rebalanceOverflowMenu('#app-nav', '#li-overflow');
+    rebalanceOverflowMenu('#page-menu', '#li-page-overflow');
 });
 
 </script>

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt