[Rt-commit] rt branch 5.0/add-full-scrip-copy-feature created. rt-5.0.4-64-ged0bf9a243

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/add-full-scrip-copy-feature has been created
        at  ed0bf9a243eca89608173972243212164a31b50b (commit)

- Log -----------------------------------------------------------------
commit ed0bf9a243eca89608173972243212164a31b50b
Author: Ronaldo Richieri <ronaldo at bestpractical.com>
Date:   Tue Jul 18 11:35:39 2023 -0300

    Add ability to copy a scrip to create new
    
    Previously, to copy the parameters from an existing scrip to a new one,
    you have to manually recreate each field.
    
    This commit adds a "Copy" link to the Modify page for a scrip.  By
    clicking the link, RT will clone the scrip and disable the new version.
    It will also copy the applied objects and stages.

diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index de2a9c6d7b..343c1f79d6 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -93,6 +93,11 @@
 
 </&>
 
+  <div class="form-row">
+    <div class="col-12">
+      <& /Elements/Submit, Label => loc('Copy Scrip'), Name => 'Copy' &>
+    </div>
+  </div>
   <div class="form-row">
     <div class="col-12">
       <& /Elements/Submit, Label => loc('Save Changes'), Name => 'Update', Reset => 1 &>
@@ -101,6 +106,11 @@
 
 % if ($session{CurrentUser}->HasRight(Object => $RT::System, Right => 'ExecuteCode')) {
 <& Elements/EditCustomCode, %ARGS, Scrip => $scrip &>
+  <div class="form-row">
+    <div class="col-12">
+      <& /Elements/Submit, Label => loc('Copy Scrip'), Name => 'Copy' &>
+    </div>
+  </div>
   <div class="form-row">
     <div class="col-12">
       <& /Elements/Submit, Label => loc('Save Changes'), Name => 'Update', Reset => 1 &>
@@ -113,6 +123,7 @@
 $id     => undef
 $Update => undef
 $From   => undef
+$Copy => undef
 </%ARGS>
 <%INIT>
 my $scrip = RT::Scrip->new( $session{'CurrentUser'} );
@@ -145,6 +156,93 @@ if ( $Update ) {
             From => $From,
         },
     );
+} elsif ($Copy) {
+    my @results;
+    my %NewScripAttributes;
+    for my $item (qw/ScripCondition ScripAction Template /) {
+        $NewScripAttributes{$item} = $scrip->$item;
+    }
+    $NewScripAttributes{'Description'} = $scrip->Description;
+    while (1) {
+        # Make sure we don't have a scrip with the same name
+        $NewScripAttributes{'Description'}
+            = loc( 'Copy of [_1]', $NewScripAttributes{'Description'} );
+        last
+            unless RT::Scrip->new( $session{'CurrentUser'} )
+            ->LoadByCols( Description => $NewScripAttributes{'Description'} );
+    }
+    if ( $session{'CurrentUser'}
+        ->HasRight( Object => $RT::System, Right => 'ExecuteCode' ) )
+    {
+        for my $item (
+            qw/CustomIsApplicableCode CustomPrepareCode CustomCommitCode/)
+        {
+            $NewScripAttributes{$item} ||= $scrip->$item;
+        }
+    }
+
+    # Make sure scrip is disabled by default
+    $NewScripAttributes{'Disabled'} = 1;
+
+    my $new_scrip = RT::Scrip->new( $session{'CurrentUser'} );
+    my ($ok, $msg) = $new_scrip->Create(%NewScripAttributes);
+    push @results, $msg;
+
+    # remove from Global to readd correctly if necessary
+    $new_scrip->RemoveFromObject(0);
+
+    # Check if scrip is global
+    my $global = $scrip->IsGlobal;
+    if ($global) {
+        if ( my $Stage = _ApplicableScripStage( scrip_id => $scrip->id ) ) {
+            $new_scrip->AddToObject( 0, Stage => $Stage );
+        }
+    } else {
+
+        # add to queues
+        my $added_to = $scrip->AddedTo;
+        while ( my $queue = $added_to->Next ) {
+
+            # check Stage
+            if (my $Stage = _ApplicableScripStage(
+                    scrip_id => $scrip->id,
+                    queue_id => $queue->id
+                )
+               )
+            {
+                $new_scrip->AddToObject( $queue->id, Stage => $Stage );
+            }
+        }
+    }
+    MaybeRedirectForResults(
+        Actions   => \@results,
+        Arguments => {
+            id   => $new_scrip->id,
+            From => $From,
+        },
+        Force => 1,
+    );
+}
+
+sub _ApplicableScripStage {
+    my %args = ( queue_id => 0, @_ );
+    for my $Stage (qw/TransactionCreate TransactionBatch/) {
+        my $scrips = RT::Scrips->new( $session{'CurrentUser'} );
+        $scrips->Limit(
+            FIELD => 'id',
+            VALUE => $args{scrip_id},
+        );
+        $scrips->LimitByStage($Stage);
+        $scrips->LimitToAdded( 0, $args{'queue_id'} );
+        $scrips->FindAllRows;
+        print STDERR "Found scrips: "
+            . $scrips->CountAll()
+            . " for scrip "
+            . $args{scrip_id}
+            . " in stage $Stage\n";
+        return $Stage if $scrips->CountAll() > 0;
+    }
+    return;
 }
 
 my $EnabledChecked = qq[checked="checked"];

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt